You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "msyavuz (via GitHub)" <gi...@apache.org> on 2025/06/16 18:10:54 UTC
Re: [PR] refactor(Menu): Use items prop instead of deprecated Menu.Item HOC [superset]
msyavuz commented on code in PR #32587:
URL: https://github.com/apache/superset/pull/32587#discussion_r2150572986
##########
superset-frontend/src/components/Dropdown/index.tsx:
##########
@@ -82,7 +82,7 @@ export enum IconOrientation {
}
export interface MenuDotsDropdownProps extends AntdDropdownProps {
- overlay: ReactElement;
+ overlay?: ReactElement;
Review Comment:
overlay prop can still be used but i made it optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org