You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Arshad Matin <ar...@gmail.com> on 2015/05/05 11:30:44 UTC
Review Request 33842: LENS-242:Add Helper class for lens-regression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-242
https://issues.apache.org/jira/browse/LENS-242
Repository: lens
Description
-------
LENS-242:Add Helper class for lens-regression
Diffs
-----
lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/APIResult.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 6bd73148738fc96e19f52137707b5aac8597448b
lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
pom.xml a0744e4da177947680a6fbc81bbab6456224b602
Diff: https://reviews.apache.org/r/33842/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
[INFO] Lens ............................................... SUCCESS [ 23.994 s]
[INFO] Lens API ........................................... SUCCESS [ 29.422 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
[INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
[INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
[INFO] Lens Server ........................................ SUCCESS [02:43 min]
[INFO] Lens client ........................................ SUCCESS [ 45.831 s]
[INFO] Lens CLI ........................................... SUCCESS [01:12 min]
[INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
[INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
[INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:10 min
[INFO] Finished at: 2015-05-05T14:50:23+05:30
[INFO] Final Memory: 94M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Arshad Matin
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 21, 2015, 10:19 a.m., Amareshwari Sriramadasu wrote:
> > pom.xml, line 956
> > <https://reviews.apache.org/r/33842/diff/2/?file=966248#file966248line956>
> >
> > test scope should be retained. Is the removal required?
>
> Arshad Matin wrote:
> Yes, As i am doing assert in core method itself.
No, we should avoid testng assert in main/java code. Can we replace it with something, throwing an exception or a guaua check? Let us not bring testng dependency into compile mode.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review84683
-----------------------------------------------------------
On May 21, 2015, 9:49 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 9:49 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Arshad Matin <ar...@gmail.com>.
> On May 21, 2015, 10:19 a.m., Amareshwari Sriramadasu wrote:
> > pom.xml, line 956
> > <https://reviews.apache.org/r/33842/diff/2/?file=966248#file966248line956>
> >
> > test scope should be retained. Is the removal required?
>
> Arshad Matin wrote:
> Yes, As i am doing assert in core method itself.
>
> Amareshwari Sriramadasu wrote:
> No, we should avoid testng assert in main/java code. Can we replace it with something, throwing an exception or a guaua check? Let us not bring testng dependency into compile mode.
Have removed assert from main/java code.
- Arshad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review84683
-----------------------------------------------------------
On May 22, 2015, 8:13 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 8:13 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Arshad Matin <ar...@gmail.com>.
> On May 21, 2015, 10:19 a.m., Amareshwari Sriramadasu wrote:
> > pom.xml, line 956
> > <https://reviews.apache.org/r/33842/diff/2/?file=966248#file966248line956>
> >
> > test scope should be retained. Is the removal required?
Yes, As i am doing assert in core method itself.
- Arshad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review84683
-----------------------------------------------------------
On May 21, 2015, 9:49 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 9:49 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review84683
-----------------------------------------------------------
Ship it!
Other changes look fine.
pom.xml
<https://reviews.apache.org/r/33842/#comment136035>
test scope should be retained. Is the removal required?
- Amareshwari Sriramadasu
On May 21, 2015, 9:49 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 9:49 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review84891
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On May 22, 2015, 8:13 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 8:13 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Arshad Matin <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/
-----------------------------------------------------------
(Updated May 22, 2015, 8:13 a.m.)
Review request for lens.
Bugs: LENS-242
https://issues.apache.org/jira/browse/LENS-242
Repository: lens
Description
-------
LENS-242:Add Helper class for lens-regression
Diffs (updated)
-----
lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
Diff: https://reviews.apache.org/r/33842/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
[INFO] Lens ............................................... SUCCESS [ 23.994 s]
[INFO] Lens API ........................................... SUCCESS [ 29.422 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
[INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
[INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
[INFO] Lens Server ........................................ SUCCESS [02:43 min]
[INFO] Lens client ........................................ SUCCESS [ 45.831 s]
[INFO] Lens CLI ........................................... SUCCESS [01:12 min]
[INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
[INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
[INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:10 min
[INFO] Finished at: 2015-05-05T14:50:23+05:30
[INFO] Final Memory: 94M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Arshad Matin
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Arshad Matin <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/
-----------------------------------------------------------
(Updated May 21, 2015, 9:49 a.m.)
Review request for lens.
Bugs: LENS-242
https://issues.apache.org/jira/browse/LENS-242
Repository: lens
Description
-------
LENS-242:Add Helper class for lens-regression
Diffs (updated)
-----
lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
Diff: https://reviews.apache.org/r/33842/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
[INFO] Lens ............................................... SUCCESS [ 23.994 s]
[INFO] Lens API ........................................... SUCCESS [ 29.422 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
[INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
[INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
[INFO] Lens Server ........................................ SUCCESS [02:43 min]
[INFO] Lens client ........................................ SUCCESS [ 45.831 s]
[INFO] Lens CLI ........................................... SUCCESS [01:12 min]
[INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
[INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
[INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:10 min
[INFO] Finished at: 2015-05-05T14:50:23+05:30
[INFO] Final Memory: 94M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Arshad Matin
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Arshad Matin <ar...@gmail.com>.
> On May 5, 2015, 6:11 p.m., Amareshwari Sriramadasu wrote:
> > Couple of comments :
> >
> > - Some code might need changes as LENS-486 went in, which changes response returned from REST api
> > - I see there is lots of code which is very similar to the code in lens-client. I'm not saying lens-regression should use lens-client. But. is it an option to consider lens-client instead of many helper methods added? If it is not immediately possible, we take it up later.
1. Will make the changes wrt the new changes went in
2. Went through lens-client API and it doesnt have API for all the REST call. As of now, its better to have a seperate helper method, later we can take a call.
- Arshad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review82542
-----------------------------------------------------------
On May 5, 2015, 9:30 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 9:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/APIResult.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 6bd73148738fc96e19f52137707b5aac8597448b
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
> pom.xml a0744e4da177947680a6fbc81bbab6456224b602
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review82542
-----------------------------------------------------------
Couple of comments :
- Some code might need changes as LENS-486 went in, which changes response returned from REST api
- I see there is lots of code which is very similar to the code in lens-client. I'm not saying lens-regression should use lens-client. But. is it an option to consider lens-client instead of many helper methods added? If it is not immediately possible, we take it up later.
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java
<https://reviews.apache.org/r/33842/#comment133282>
Rename to Grill to Lens? This is the same all helpers.
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java
<https://reviews.apache.org/r/33842/#comment133283>
Is this same as assertNotNull ?
lens-regression/src/main/java/org/apache/lens/regression/core/type/APIResult.java
<https://reviews.apache.org/r/33842/#comment133285>
Cannot we use APIResult from lens-api ?
pom.xml
<https://reviews.apache.org/r/33842/#comment133281>
Can we use glassfish jersey than com.sun ?
- Amareshwari Sriramadasu
On May 5, 2015, 9:30 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 9:30 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/APIResult.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 6bd73148738fc96e19f52137707b5aac8597448b
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
> pom.xml a0744e4da177947680a6fbc81bbab6456224b602
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Arshad Matin <ar...@gmail.com>.
> On May 20, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java, line 61
> > <https://reviews.apache.org/r/33842/diff/1/?file=949851#file949851line61>
> >
> > Should have a reliable way of determining whether server is up or not. Sometimes 5 sec won't be enough.
Actually 5 sec is the time interval in which it pool. It will continously pool until server comes up
- Arshad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review84503
-----------------------------------------------------------
On May 21, 2015, 9:49 a.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 9:49 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java e58b30822bfe5787e142124bcbce81ad302ff521
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
> pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>
Re: Review Request 33842: LENS-242:Add Helper class for
lens-regression
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33842/#review84503
-----------------------------------------------------------
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java
<https://reviews.apache.org/r/33842/#comment135820>
Should have a reliable way of determining whether server is up or not. Sometimes 5 sec won't be enough.
- Rajat Khandelwal
On May 5, 2015, 3 p.m., Arshad Matin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33842/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-242
> https://issues.apache.org/jira/browse/LENS-242
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-242:Add Helper class for lens-regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml 037b2e9ee7ce195ffc3008823417f25b62e02e17
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/MetastoreURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/APIResult.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/FormBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/PrepareQueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/core/type/QueryHandles.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java PRE-CREATION
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 6bd73148738fc96e19f52137707b5aac8597448b
> lens-regression/src/test/java/org/apache/lens/regression/sanity/ITSmokeTest.java 7f462a996a0902989086e505f6145ac7798013fb
> pom.xml a0744e4da177947680a6fbc81bbab6456224b602
>
> Diff: https://reviews.apache.org/r/33842/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 31.984 s]
> [INFO] Lens ............................................... SUCCESS [ 23.994 s]
> [INFO] Lens API ........................................... SUCCESS [ 29.422 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 43.284 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.038 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 26.845 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 32.671 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 30.189 s]
> [INFO] Lens Server ........................................ SUCCESS [02:43 min]
> [INFO] Lens client ........................................ SUCCESS [ 45.831 s]
> [INFO] Lens CLI ........................................... SUCCESS [01:12 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.281 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 59.876 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:28 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 56.029 s]
> [INFO] Lens Regression .................................... SUCCESS [ 39.851 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:10 min
> [INFO] Finished at: 2015-05-05T14:50:23+05:30
> [INFO] Final Memory: 94M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Arshad Matin
>
>