You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/02/04 18:47:51 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1335: SOLR-16531: Disable unused Jersey features
gerlowskija opened a new pull request, #1335:
URL: https://github.com/apache/solr/pull/1335
https://issues.apache.org/jira/browse/SOLR-16531
# Description
Jersey has several optional features that we don't need or use. Disabling these keeps our use of Jersey as lightweight as possible.
# Solution
These features are disabled by setting particular configuration props in each Jersey 'application' that gets created.
# Tests
Manually tested via log-message inspection. Manual validation of the improved Jersey app-startup performance. Existing tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a diff in pull request #1335: SOLR-16531: Disable unused Jersey features
Posted by "madrob (via GitHub)" <gi...@apache.org>.
madrob commented on code in PR #1335:
URL: https://github.com/apache/solr/pull/1335#discussion_r1096583404
##########
solr/core/src/java/org/apache/solr/jersey/JerseyApplications.java:
##########
@@ -79,6 +80,16 @@ protected void configure() {
.in(RequestScoped.class);
}
});
+
+ setProperties(
+ Map.of(
+ "jersey.config.server.wadl.disableWadl", "true",
+ "jersey.config.beanValidation.disable.server", "true",
+ "jersey.config.server.disableAutoDiscovery", "true",
+ "jersey.config.server.disableJsonProcessing", "true",
+ "jersey.config.server.disableMetainfServicesLookup", "true",
+ "jersey.config.server.disableMoxyJson", "true",
+ "jersey.config.server.resource.validation.disable", "true"));
// Logging - disabled by default but useful for debugging Jersey execution
// setProperties(
// Map.of(
Review Comment:
Fold this comment into the previous setProperties call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1335: SOLR-16531: Disable unused Jersey features
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1335:
URL: https://github.com/apache/solr/pull/1335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1335: SOLR-16531: Disable unused Jersey features
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1335:
URL: https://github.com/apache/solr/pull/1335#issuecomment-1419169682
Alright, thanks for the reviews guys. Aiming to merge this later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1335: SOLR-16531: Disable unused Jersey features
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1335:
URL: https://github.com/apache/solr/pull/1335#issuecomment-1416824188
This PR consists mainly of a snippet that I've had in a variety of other Jersey-related PRs, and that has been previously reviewed. Pulling it into its own PR here, so that it's better documented in the git-log, can be reverted or cherry-picked independently, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org