You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Timothy Bish (Created) (JIRA)" <ji...@apache.org> on 2011/12/14 17:45:30 UTC

[jira] [Created] (AMQNET-360) ActiveMQ client ResponseCorrelator doesn't handle ExceptionResponse commands correctly.

ActiveMQ client ResponseCorrelator doesn't handle ExceptionResponse commands correctly.
---------------------------------------------------------------------------------------

                 Key: AMQNET-360
                 URL: https://issues.apache.org/jira/browse/AMQNET-360
             Project: ActiveMQ .Net
          Issue Type: Bug
          Components: ActiveMQ
    Affects Versions: 1.5.2, 1.5.1, 1.5.0
            Reporter: Timothy Bish
            Assignee: Timothy Bish
            Priority: Minor
             Fix For: 1.6.0


The current implementation of the ResponseCorrelator deals with exception responses by calling the transport exception listener as well as throwing an exception from the request methods instead of just returning the ExceptionResponse message and allowing the caller to deal with the error.  This prevents the caller from being able to recover from non-critical messages as the ExceptionListener calls marks the transport as failed in the Connection when it needn't be.  The correct operation should be for the ExceptionResponse to be propagated to the caller (Connection) and allow that to deal with the error.

This is needed so that cases like TransactionRollbackException's returned from Commit requests when a failover occurs and the State Tracker rolls back the transaction because its state is in doubt.  This is not a critical error and the Connection should be allowed to continue after this.  Other cases similar to this also exist.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (AMQNET-360) ActiveMQ client ResponseCorrelator doesn't handle ExceptionResponse commands correctly.

Posted by "Timothy Bish (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQNET-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQNET-360.
---------------------------------

    Resolution: Fixed

fix applied in trunk
                
> ActiveMQ client ResponseCorrelator doesn't handle ExceptionResponse commands correctly.
> ---------------------------------------------------------------------------------------
>
>                 Key: AMQNET-360
>                 URL: https://issues.apache.org/jira/browse/AMQNET-360
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: ActiveMQ
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> The current implementation of the ResponseCorrelator deals with exception responses by calling the transport exception listener as well as throwing an exception from the request methods instead of just returning the ExceptionResponse message and allowing the caller to deal with the error.  This prevents the caller from being able to recover from non-critical messages as the ExceptionListener calls marks the transport as failed in the Connection when it needn't be.  The correct operation should be for the ExceptionResponse to be propagated to the caller (Connection) and allow that to deal with the error.
> This is needed so that cases like TransactionRollbackException's returned from Commit requests when a failover occurs and the State Tracker rolls back the transaction because its state is in doubt.  This is not a critical error and the Connection should be allowed to continue after this.  Other cases similar to this also exist.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira