[jira] [Issue Comment Edited] (CONNECTORS-341) override config for test cases

["Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CONNECTORS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177124#comment-13177124 ] 

Karl Wright edited comment on CONNECTORS-341 at 12/29/11 11:53 AM:
-------------------------------------------------------------------

I had been toying with moving these embedded configuration files to src/test/resource instead.  It sounds like that would mess up your use case entirely though.

I like the fact that "initialize()" can be separately overridden, but I'd like perhaps to take it a step further and provide a base class method that is specifically meant to be overridden such that the values written can be extended rather than completely replaced, e.g.:

{code}
protected void populateConfigurationXML(StringBuilder sb)
{
...
}
{code}

... which is called from the base class implementation of initialize().  Also a similar method for logging.ini.  Do you understand what I mean, and if so do you want to modify your patch accordingly?

                
      was (Author: kwright@metacarta.com):
    I had been toying with moving these embedded configuration files to src/test/resource instead.  It sounds like that would mess up your use case entirely though.

I like the fact that "initialize()" can be separately overridden, but I'd like perhaps to take it a step further and provide a base class method that is specifically meant to be overridden such that the values written can be extended rather than completely replaced, e.g.:

protected void populateConfigurationXML(StringBuilder sb)
{
...
}

... which is called from the base class implementation of initialize().  Also a similar method for logging.ini.  Do you understand what I mean, and if so do you want to modify your patch accordingly?

                  
> override config for test cases
> ------------------------------
>
>                 Key: CONNECTORS-341
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-341
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Martin Goldhahn
>         Attachments: CONNECTORS-341.patch
>
>
> It is hard to write a test case for a repository connector using the existing *.Base classes that uses a different config file.
> The config files are actually written in org.apache.manifoldcf.core.tests.Base.localSetup().
> The localSetup method is called by all sub-classes in their overridden localSetup function. each sub-class adds something specific for the test case. If I wanted to put something different in the config files I had to override localSetup() and copy all content of the superclasses' localSetup to it. This can be avoided by moving the code that writes the config file in the initialize() method. It makes also more sense in that the creation of the config files and the provision of their content are now in the same function.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira