You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2018/10/25 07:18:52 UTC

Review Request 69154: RANGER-2266:To make Id to ID in Audit Pages of Ranger Admin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69154/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, Velmurugan Periasamy, and Zsombor Gegesy.


Bugs: RANGER-2266
    https://issues.apache.org/jira/browse/RANGER-2266


Repository: ranger


Description
-------

The ID in the Audit web pages of Ranger Admin is not uniform.
There are two ways to write in the pages: Id and ID.
In Access,		 	Table Head: Policy ID
In Admin,  			Table Head and Search Options: Session Id
In Login Sessions, 	Table Head and Search Options: Session Id, Login Id
In Plugins,			Table Head: Plugin Id, but Search Options: Plugin ID
Please check the following screenshots:
[Access|https://issues.apache.org/jira/secure/attachment/12945554/Access_PolicyID.jpg]
[Admin|https://issues.apache.org/jira/secure/attachment/12945555/Admin_SessionID.jpg]
[Login Sessions|https://issues.apache.org/jira/secure/attachment/12945556/LoginSeeions_LoginIDandSessionID.jpg]
[Plugins|https://issues.apache.org/jira/secure/attachment/12945557/Plugins_PluginID.jpg]


Diffs
-----

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 19cc7b4 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 3da1567 


Diff: https://reviews.apache.org/r/69154/diff/1/


Testing
-------

Change Id to ID in Audit Pages of Ranger Admin
Tested.


Thanks,

Qiang Zhang


Re: Review Request 69154: RANGER-2266:To make Id to ID in Audit Pages of Ranger Admin

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69154/#review210219
-----------------------------------------------------------


Ship it!




Ship It!

- Nitin Galave


On Oct. 25, 2018, 7:18 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69154/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2018, 7:18 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, Velmurugan Periasamy, and Zsombor Gegesy.
> 
> 
> Bugs: RANGER-2266
>     https://issues.apache.org/jira/browse/RANGER-2266
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The ID in the Audit web pages of Ranger Admin is not uniform.
> There are two ways to write in the pages: Id and ID.
> In Access,		 	Table Head: Policy ID
> In Admin,  			Table Head and Search Options: Session Id
> In Login Sessions, 	Table Head and Search Options: Session Id, Login Id
> In Plugins,			Table Head: Plugin Id, but Search Options: Plugin ID
> Please check the following screenshots:
> [Access|https://issues.apache.org/jira/secure/attachment/12945554/Access_PolicyID.jpg]
> [Admin|https://issues.apache.org/jira/secure/attachment/12945555/Admin_SessionID.jpg]
> [Login Sessions|https://issues.apache.org/jira/secure/attachment/12945556/LoginSeeions_LoginIDandSessionID.jpg]
> [Plugins|https://issues.apache.org/jira/secure/attachment/12945557/Plugins_PluginID.jpg]
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 19cc7b4 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 3da1567 
> 
> 
> Diff: https://reviews.apache.org/r/69154/diff/1/
> 
> 
> Testing
> -------
> 
> Change Id to ID in Audit Pages of Ranger Admin
> Tested.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 69154: RANGER-2266:To make Id to ID in Audit Pages of Ranger Admin

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69154/#review210129
-----------------------------------------------------------


Ship it!




Ship It!

- pengjianhua


On 十月 25, 2018, 7:18 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69154/
> -----------------------------------------------------------
> 
> (Updated 十月 25, 2018, 7:18 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat Ranganathan, Velmurugan Periasamy, and Zsombor Gegesy.
> 
> 
> Bugs: RANGER-2266
>     https://issues.apache.org/jira/browse/RANGER-2266
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The ID in the Audit web pages of Ranger Admin is not uniform.
> There are two ways to write in the pages: Id and ID.
> In Access,		 	Table Head: Policy ID
> In Admin,  			Table Head and Search Options: Session Id
> In Login Sessions, 	Table Head and Search Options: Session Id, Login Id
> In Plugins,			Table Head: Plugin Id, but Search Options: Plugin ID
> Please check the following screenshots:
> [Access|https://issues.apache.org/jira/secure/attachment/12945554/Access_PolicyID.jpg]
> [Admin|https://issues.apache.org/jira/secure/attachment/12945555/Admin_SessionID.jpg]
> [Login Sessions|https://issues.apache.org/jira/secure/attachment/12945556/LoginSeeions_LoginIDandSessionID.jpg]
> [Plugins|https://issues.apache.org/jira/secure/attachment/12945557/Plugins_PluginID.jpg]
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 19cc7b4 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 3da1567 
> 
> 
> Diff: https://reviews.apache.org/r/69154/diff/1/
> 
> 
> Testing
> -------
> 
> Change Id to ID in Audit Pages of Ranger Admin
> Tested.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>