You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "CV-Bowen (via GitHub)" <gi...@apache.org> on 2024/10/12 08:01:27 UTC
[PR] drivers/pci: fix pci framework warning in 32bit chip [nuttx]
CV-Bowen opened a new pull request, #14165:
URL: https://github.com/apache/nuttx/pull/14165
## Summary
In file included from pci/pci.c:30:
pci/pci.c: In function 'pci_setup_device':
pci/pci.c:449:66: warning: right shift count >= width of type [-Wshift-count-overflow]
449 | pci_write_config_dword(dev, base_address_1, res->start >> 32);
| ^~
pci/pci.c: In function 'pci_presetup_bridge':
pci/pci.c:541:51: warning: right shift count >= width of type [-Wshift-count-overflow]
541 | ctrl->mem_pref.start >> 32);
| ^~
pci/pci.c: In function 'pci_postsetup_bridge':
pci/pci.c:604:57: warning: right shift count >= width of type [-Wshift-count-overflow]
604 | (ctrl->mem_pref.start - 1) >> 32);
| ^~
CC: pthread/pthread_release.c pci/pci_ecam.c:71:12: warning: initialization of 'int (*)(struct pci_bus_s *, unsigned int, int, int, uint32_t *)' {aka 'int (*)(struct pci_bus_s *, unsigned int, int, int, long unsigned int *)'} from incompatible pointer type 'int (*)(struct pci_bus_s *, uint32_t, int, int, uint32_t *)' {aka 'int (*)(struct pci_bus_s *, long unsigned int, int, int, long unsigned int *)'} [-Wincompatible-pointer-types]
71 | .read = pci_ecam_read_config,
| ^~~~~~~~~~~~~~~~~~~~
pci/pci_ecam.c:71:12: note: (near initialization for 'g_pci_ecam_ops.read')
pci/pci_ecam.c:72:12: warning: initialization of 'int (*)(struct pci_bus_s *, unsigned int, int, int, uint32_t)' {aka 'int (*)(struct pci_bus_s *, unsigned int, int, int, long unsigned int)'} from incompatible pointer type 'int (*)(struct pci_bus_s *, uint32_t, int, int, uint32_t)' {aka 'int (*)(struct pci_bus_s *, long unsigned int, int, int, long unsigned int)'} [-Wincompatible-pointer-types]
72 | .write = pci_ecam_write_config,
## Impact
PCI
## Testing
qemu armv8a and qemu intel64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: fix pci framework warning in 32bit chip [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14165:
URL: https://github.com/apache/nuttx/pull/14165#issuecomment-2408452338
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The provided PR information lacks crucial details to assess its adherence to NuttX requirements. Here's a breakdown:
**What's Missing & Why It Matters:**
* **Summary:** The summary only mentions warnings related to right shift count and incompatible pointer types in the PCI code. This is insufficient.
* **Why is the change necessary?** Are these warnings causing actual issues, or are they false positives?
* **What's the solution?** How are these warnings being addressed? A simple cast might hide a deeper problem.
* **Issue/PR References:** Are there any related issues in the NuttX or NuttX Apps repositories? Providing links gives context.
* **Impact:** Simply stating "PCI" isn't informative enough.
* **Functionality:** Does this PR fix a bug, enhance performance, or introduce a new PCI feature?
* **User Impact:** Will users need to modify their configurations or code?
* **Hardware Impact:** Will specific architectures, boards, or PCI devices be affected?
* **Security/Compatibility:** Are there any security implications or backward compatibility concerns?
* **Testing:** The testing information is vague.
* **Build Hosts:** Specify the operating systems, CPUs, and compiler versions used for building NuttX.
* **Target Details:** Provide specific details about the QEMU configurations (e.g., QEMU version, machine type, CPU model) used for armv8a and intel64 testing.
* **Testing Logs:** Instead of "your testing logs here," provide relevant snippets of logs demonstrating the warnings before the change and their absence (or expected behavior) after the change.
**Verdict:**
The PR, in its current form, **does not meet NuttX requirements.** It lacks essential details about the problem, the solution, its impact, and thorough testing evidence. More information is needed to properly review and merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] drivers/pci: fix pci framework warning in 32bit chip [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14165:
URL: https://github.com/apache/nuttx/pull/14165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org