You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "yejiabao (Code Review)" <ge...@cloudera.org> on 2021/07/10 04:16:58 UTC

[kudu-CR] [scripts] modified the minidump usage guide

Hello Mike Percy,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/17670

to review the following change.


Change subject: [scripts] modified the minidump usage guide
......................................................................

[scripts] modified the minidump usage guide

Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
---
M src/kudu/scripts/dump_breakpad_symbols.py
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/17670/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
Gerrit-Change-Number: 17670
Gerrit-PatchSet: 1
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [scripts] KUDU-3303 modified the minidump usage guide

Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17670

to look at the new patch set (#4).

Change subject: [scripts] KUDU-3303 modified the minidump usage guide
......................................................................

[scripts] KUDU-3303 modified the minidump usage guide

Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
---
M src/kudu/scripts/dump_breakpad_symbols.py
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/17670/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
Gerrit-Change-Number: 17670
Gerrit-PatchSet: 4
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [scripts] KUDU-3303 modified the minidump usage guide

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17670 )

Change subject: [scripts] KUDU-3303 modified the minidump usage guide
......................................................................

[scripts] KUDU-3303 modified the minidump usage guide

Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
Reviewed-on: http://gerrit.cloudera.org:8080/17670
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/scripts/dump_breakpad_symbols.py
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
Gerrit-Change-Number: 17670
Gerrit-PatchSet: 5
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [scripts] modified the minidump usage guide

Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17670

to look at the new patch set (#2).

Change subject: [scripts] modified the minidump usage guide
......................................................................

[scripts] modified the minidump usage guide

Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
---
M src/kudu/scripts/dump_breakpad_symbols.py
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/17670/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
Gerrit-Change-Number: 17670
Gerrit-PatchSet: 2
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [scripts] KUDU-3303 modified the minidump usage guide

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17670 )

Change subject: [scripts] KUDU-3303 modified the minidump usage guide
......................................................................


Patch Set 4: Code-Review+2

Thank you for the patch!


-- 
To view, visit http://gerrit.cloudera.org:8080/17670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d745e2bbd5287e5ee389b63bdb33abbae525cb
Gerrit-Change-Number: 17670
Gerrit-PatchSet: 4
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 02 Aug 2021 22:53:40 +0000
Gerrit-HasComments: No