You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by jf...@apache.org on 2020/01/09 10:50:23 UTC

[incubator-iotdb] 01/01: Made all tests Locale Invariant by always explicitly defaulting to Locale.ENGLISH.

This is an automated email from the ASF dual-hosted git repository.

jfeinauer pushed a commit to branch bugfix/fails-on-ger-locale
in repository https://gitbox.apache.org/repos/asf/incubator-iotdb.git

commit 9a78d2dcc3bf1120254ae5cbc712262cb72b5790
Author: julian <j....@pragmaticminds.de>
AuthorDate: Thu Jan 9 11:50:07 2020 +0100

    Made all tests Locale Invariant by always explicitly defaulting to Locale.ENGLISH.
---
 .../java/org/apache/iotdb/db/integration/IoTDBDeletionIT.java     | 4 ++--
 .../org/apache/iotdb/db/integration/IoTDBFlushQueryMergeTest.java | 8 +++++---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/server/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionIT.java b/server/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionIT.java
index 6eaad79..dec0a62 100644
--- a/server/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionIT.java
+++ b/server/src/test/java/org/apache/iotdb/db/integration/IoTDBDeletionIT.java
@@ -236,12 +236,12 @@ public class IoTDBDeletionIT {
 
       // prepare BufferWrite data
       for (int i = 10001; i <= 20000; i++) {
-        statement.execute(String.format(insertTemplate, i, i, i, (double) i, "\'" + i + "\'",
+        statement.execute(String.format(Locale.ENGLISH, insertTemplate, i, i, i, (double) i, "\'" + i + "\'",
             i % 2 == 0));
       }
       // prepare Overflow data
       for (int i = 1; i <= 10000; i++) {
-        statement.execute(String.format(insertTemplate, i, i, i, (double) i, "\'" + i + "\'",
+        statement.execute(String.format(Locale.ENGLISH, insertTemplate, i, i, i, (double) i, "\'" + i + "\'",
             i % 2 == 0));
       }
 
diff --git a/server/src/test/java/org/apache/iotdb/db/integration/IoTDBFlushQueryMergeTest.java b/server/src/test/java/org/apache/iotdb/db/integration/IoTDBFlushQueryMergeTest.java
index c3c9513..4bc6150 100644
--- a/server/src/test/java/org/apache/iotdb/db/integration/IoTDBFlushQueryMergeTest.java
+++ b/server/src/test/java/org/apache/iotdb/db/integration/IoTDBFlushQueryMergeTest.java
@@ -25,6 +25,8 @@ import java.sql.Connection;
 import java.sql.DriverManager;
 import java.sql.ResultSet;
 import java.sql.Statement;
+import java.util.Locale;
+
 import org.apache.iotdb.db.conf.IoTDBDescriptor;
 import org.apache.iotdb.db.service.IoTDB;
 import org.apache.iotdb.db.utils.EnvironmentUtils;
@@ -124,14 +126,14 @@ public class IoTDBFlushQueryMergeTest {
 
       for (int i = 1; i <= 3; i++) {
         for (int j = 10; j < 20; j++) {
-          statement.execute(String.format(insertTemplate, i, j, j, j*0.1, String.valueOf(j)));
+          statement.execute(String.format(Locale.ENGLISH, insertTemplate, i, j, j, j*0.1, String.valueOf(j)));
         }
       }
       statement.execute("FLUSH");
 
       for (int i = 1; i <= 3; i++) {
         for (int j = 0; j < 10; j++) {
-          statement.execute(String.format(insertTemplate, i, j, j, j*0.1, String.valueOf(j)));
+          statement.execute(String.format(Locale.ENGLISH, insertTemplate, i, j, j, j*0.1, String.valueOf(j)));
         }
       }
       statement.execute("FLUSH root.group1");
@@ -139,7 +141,7 @@ public class IoTDBFlushQueryMergeTest {
 
       for (int i = 1; i <= 3; i++) {
         for (int j = 0; j < 30; j++) {
-          statement.execute(String.format(insertTemplate, i, j, j, j*0.1, String.valueOf(j)));
+          statement.execute(String.format(Locale.ENGLISH, insertTemplate, i, j, j, j*0.1, String.valueOf(j)));
         }
       }
       statement.execute("FLUSH root.group1 true");