You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2019/05/21 13:34:13 UTC
[pulsar] branch master updated: [ISSUE #4101] Fix Javadoc for
ClientBuilder.keepAliveInterval
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 4d9351d [ISSUE #4101] Fix Javadoc for ClientBuilder.keepAliveInterval
4d9351d is described below
commit 4d9351d2ffa4d5031e9db7194639cd286bef94da
Author: wpl <12...@qq.com>
AuthorDate: Tue May 21 21:34:07 2019 +0800
[ISSUE #4101] Fix Javadoc for ClientBuilder.keepAliveInterval
Fixes #4101
### Motivation
fix issue
### Modifications
fix keepAliveInterval method java doc
---
.../java/org/apache/pulsar/client/api/ClientBuilder.java | 12 ++++++------
.../org/apache/pulsar/client/impl/ClientBuilderImpl.java | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
index a99d08b..eb02c3f 100644
--- a/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
+++ b/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
@@ -292,9 +292,9 @@ public interface ClientBuilder extends Cloneable {
/**
* Set the interval between each stat info <i>(default: 60 seconds)</i> Stats will be activated with positive
- * statsIntervalSeconds It should be set to at least 1 second
+ * statsInterval It should be set to at least 1 second
*
- * @param statsIntervalSeconds
+ * @param statsInterval
* the interval between each stat info
* @param unit
* time unit for {@code statsInterval}
@@ -334,13 +334,13 @@ public interface ClientBuilder extends Cloneable {
ClientBuilder maxNumberOfRejectedRequestPerConnection(int maxNumberOfRejectedRequestPerConnection);
/**
- * Set keep alive interval in seconds for each client-broker-connection. <i>(default: 30)</i>.
+ * Set keep alive interval for each client-broker-connection. <i>(default: 30 seconds)</i>.
*
- * @param keepAliveIntervalSeconds
- * @param unit time unit for {@code statsInterval}
+ * @param keepAliveInterval
+ * @param unit the time unit in which the keepAliveInterval is defined
* @return the client builder instance
*/
- ClientBuilder keepAliveInterval(int keepAliveIntervalSeconds, TimeUnit unit);
+ ClientBuilder keepAliveInterval(int keepAliveInterval, TimeUnit unit);
/**
* Set the duration of time to wait for a connection to a broker to be established. If the duration passes without a
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
index a44d286..013e94d 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java
@@ -197,8 +197,8 @@ public class ClientBuilderImpl implements ClientBuilder {
}
@Override
- public ClientBuilder keepAliveInterval(int keepAliveIntervalSeconds, TimeUnit unit) {
- conf.setKeepAliveIntervalSeconds((int)unit.toSeconds(keepAliveIntervalSeconds));
+ public ClientBuilder keepAliveInterval(int keepAliveInterval, TimeUnit unit) {
+ conf.setKeepAliveIntervalSeconds((int)unit.toSeconds(keepAliveInterval));
return this;
}