You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/01 23:40:52 UTC

[GitHub] [beam] robertwb commented on a change in pull request #12749: [BEAM-10720] Add implementation for elementwise str methods

robertwb commented on a change in pull request #12749:
URL: https://github.com/apache/beam/pull/12749#discussion_r481490737



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -200,6 +200,15 @@ def update(self, other):
 
   view = frame_base.wont_implement_method('memory sharing semantics')
 
+  @property
+  def str(self):
+    expr = expressions.ComputedExpression(
+        'str',
+        lambda df: df.str, [self._expr],
+        requires_partition_by=partitionings.Nothing(),
+        preserves_partition_by=partitionings.Nothing())

Review comment:
       Doesn't it preserve all partitionings? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org