You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/29 22:25:16 UTC
[GitHub] [airflow] tsingh2k15 opened a new pull request #19881: remove upper bound for MarkupSafe
tsingh2k15 opened a new pull request #19881:
URL: https://github.com/apache/airflow/pull/19881
Per discussion and guidance from #19753, opening this PR for review. Based on if all the tests pass, this could be reviewed further. Resolves #19761
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 edited a comment on pull request #19881: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 edited a comment on pull request #19881:
URL: https://github.com/apache/airflow/pull/19881#issuecomment-982964904
> scheduler
Thanks for clarification! I will investigate the other ones and test if restricting upper bound to an acceptable version fixes those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 commented on pull request #19881: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 commented on pull request #19881:
URL: https://github.com/apache/airflow/pull/19881#issuecomment-982209469
@potiuk There are test failures again on this new PR. I looked at some of the logs and noticed below error. Thoughts?
```
> assert DagRun.active_runs_of_dags(session=session) == {'test_dag': 3}
E AssertionError: assert {'test_dag': ...cheduling': 1} == {'test_dag': 3}
E Omitting 1 identical items, use -vv to show
E Left contains 1 more item:
E {'test_task_start_date_scheduling': 1}
E Use -v to get the full diff
tests/jobs/test_scheduler_job.py:2910: AssertionError
```
https://github.com/apache/airflow/blob/main/tests/jobs/test_scheduler_job.py#L2910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #19881: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #19881:
URL: https://github.com/apache/airflow/pull/19881#issuecomment-982919116
I am trying to investigate and fix flaky tests from this very job in #19860 - but the last remaining one is rather puzzling (and this migh be reason for this one) - but there are other "views" related which I have not seen elsewhere (and they are quite likely for markup-safe)
In short - don't worry about scheduler, but the view ones are likely to be caused by markup upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19881: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19881:
URL: https://github.com/apache/airflow/pull/19881#issuecomment-982919116
I am trying to investigate and fix flaky tests from this very job in #19860 - but the last remaining one is rather puzzling (and this migh be reason for this one) - but there are other "viwes" related which I have not seen elsewhere (and they are quite likely for markup-safe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 commented on pull request #19881: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 commented on pull request #19881:
URL: https://github.com/apache/airflow/pull/19881#issuecomment-982964904
> scheduler
Thanks for clarification! I will investigate the other ones and see if restricting upper bound to an acceptable version fixes those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 closed pull request #19881: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 closed pull request #19881:
URL: https://github.com/apache/airflow/pull/19881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org