You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/01/26 20:28:58 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #16625: [BEAM-13537] Fix NPE in kafkatopubsub example

TheNeuralBit commented on a change in pull request #16625:
URL: https://github.com/apache/beam/pull/16625#discussion_r793021931



##########
File path: examples/java/src/main/java/org/apache/beam/examples/complete/kafkatopubsub/options/KafkaToPubsubOptions.java
##########
@@ -90,6 +91,7 @@
 
   @Description(
       "Additional kafka consumer configs to be applied to Kafka Consumer (e.g. key1=value1;key2=value2).")
+  @Nullable

Review comment:
       @kennknowles do you think there's anything we can do to enforce that pipeline options without a default are `Nullable`? If we'd had that checkerframework would have caught this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org