[GitHub] [airflow] mik-laj commented on a change in pull request #12140: Retry Publishing Task to Celery Broker

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #12140:
URL: https://github.com/apache/airflow/pull/12140#discussion_r519146522



##########
File path: airflow/executors/celery_executor.py
##########
@@ -262,10 +268,26 @@ def _process_tasks(self, task_tuples_to_send: List[TaskInstanceInCelery]) -> Non
         self.log.debug('Sent all tasks.')
 
         for key, _, result in key_and_async_results:
+            if isinstance(result, ExceptionWithTraceback) and isinstance(
+                result.exception, AirflowTaskTimeout
+            ):
+                if key in self.task_publish_retries and (
+                    self.task_publish_retries.get(key) <= self.task_publish_max_retries
+                ):
+                    Stats.incr("celery.task_timeout_error")

Review comment:
       Should we add this metric to https://airflow.readthedocs.io/en/latest/logging-monitoring/metrics.html?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org