You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lu...@apache.org on 2019/08/26 07:12:47 UTC
[incubator-weex] 01/10: Revert "[Android] Android] restart
weexCoreThread when reload JSEngine because thread maybe in lock state and
can't execute reload action (block) (#2824)"
This is an automated email from the ASF dual-hosted git repository.
luckychen pushed a commit to branch feature/0.26.2.19-jit
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git
commit a608301233d230da0bc3100f4c81ada4a87200ea
Author: chen <qh...@gmail.com>
AuthorDate: Thu Aug 15 11:32:16 2019 +0800
Revert "[Android] Android] restart weexCoreThread when reload JSEngine because thread maybe in lock state and can't execute reload action (block) (#2824)"
This reverts commit c72e6b5a833f66ed048042d1e4fb385aa61ed97c.
---
.../java/com/taobao/weex/bridge/WXBridgeManager.java | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index 145730c..91aba2a 100755
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
@@ -867,14 +867,6 @@ public class WXBridgeManager implements Callback, BactchExecutor {
}
- public void restartWeexCoreThread(){
- WXLogUtils.e("weex","restartWeexCoreThread");
- WXThread oldThread = mJSThread;
- mJSThread = new WXThread("WeexJSBridgeThread", this);
- mJSHandler = mJSThread.getHandler();
- oldThread.quit();
- }
-
public int callReportCrashReloadPage(String instanceId, String crashFile) {
boolean isCrashFileEmpty = TextUtils.isEmpty(crashFile);
try {
@@ -926,17 +918,6 @@ public class WXBridgeManager implements Callback, BactchExecutor {
if (WXSDKManager.getInstance().getSDKInstance(instanceId) != null) {
boolean reloadThisInstance = shouldReloadCurrentInstance(
WXSDKManager.getInstance().getSDKInstance(instanceId).getBundleUrl());
- boolean restartCoreThread = true;
- IWXConfigAdapter adapter = WXSDKManager.getInstance().getWxConfigAdapter();
- if (null != adapter){
- String config = adapter.getConfig("wxapm","restartCoreThread","true");
- restartCoreThread = Boolean.valueOf(config);
- }
- if (restartCoreThread){
- WXBridgeManager.getInstance().restartWeexCoreThread();
- }
- WXSDKManager.getInstance().getSDKInstance(instanceId).getContainerInfo()
- .put("restartWeexCoreThread",String.valueOf(restartCoreThread));
new ActionReloadPage(instanceId, reloadThisInstance).executeAction();
}