Re: [PR] HDDS-13621. NPE in OzoneManagerRatisServer.checkRetryCache [ozone]

["szetszwo (via GitHub)" <gi...@apache.org>]

szetszwo commented on code in PR #9016:
URL: https://github.com/apache/ozone/pull/9016#discussion_r2334241301


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java:
##########
@@ -537,7 +537,11 @@ public OMResponse checkRetryCache() throws ServiceException {
     }
     //cache hit
     try {
-      return getOMResponse(cacheEntry.getReplyFuture().get());
+      RaftClientReply reply = cacheEntry.getReplyFuture().get();
+      if(!reply.isSuccess()) {
+        return null;
+      }

Review Comment:
   @ss77892 , thanks for working on this!
   
   If `isSuccess() == false`, returning null will trigger a retry.  Then, it is not idempotent (HDDS-11558).  Instead, we should return a failure response.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org