You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "gneworld (via GitHub)" <gi...@apache.org> on 2024/10/14 08:23:04 UTC
[PR] thttpd:fix Coding Style Check Failed issue [nuttx-apps]
gneworld opened a new pull request, #2723:
URL: https://github.com/apache/nuttx-apps/pull/2723
## Summary
error: Mixed case identifier found
## Impact
thttpd
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] thttpd:fix Coding Style Check Failed issue [nuttx-apps]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2723:
URL: https://github.com/apache/nuttx-apps/pull/2723#issuecomment-2410427132
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**No, this PR does not meet the NuttX requirements.**
**Missing Information:**
* **Insufficient Summary:** The summary lacks crucial details. It doesn't explain the necessary change, the affected code section, the mechanics of the change, or any related issues.
* **Vague Impact:** The impact section only mentions "thttpd," leaving it unclear how the change affects it. Specific impacts on users, builds, hardware, documentation, security, and compatibility are missing.
* **Inadequate Testing:** The testing section lacks essential information such as:
* Specific build host details (OS, CPU, compiler version)
* Target details (architecture, board, configuration)
* Descriptive testing logs demonstrating functionality before and after the change.
**Recommendations:**
1. **Expand the Summary:** Provide a comprehensive overview of the change's purpose, affected code, functionality, and related issues.
2. **Detail the Impact:** Explain the specific consequences of the change for each aspect (user, build, hardware, etc.). If there is no impact, explicitly state "None."
3. **Thoroughly Describe Testing:** Include specific details about your build host, target environment, and provide clear, descriptive testing logs to demonstrate the change's effect.
By addressing these points, you'll significantly improve the PR's clarity and adherence to NuttX standards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] thttpd:fix Coding Style Check Failed issue [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2723:
URL: https://github.com/apache/nuttx-apps/pull/2723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org