[jira] [Updated] (YARN-4447) Provide a mechanism to represent complex filters and parse them at the REST layer

["Varun Saxena (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Varun Saxena updated YARN-4447:
-------------------------------
    Attachment: YARN-4447-YARN-2928.02.patch

Updating a new patch addressing most of the comments given above. 
Havent yet handled the mutable filters issue.

Have removed TimelineParseUtils and used String#startsWith to check for AND/OR and compare ops'. startsWith uses char array internally so should be similar to what I was doing. 
As we will have to convert the whole expression to lowercase again and again(which would mean complete parse of string again and again), keeping a copy of it in lower case along with the main expression(converting the main expression to lower case in constructor). Thoughts on the approach ?

Also added a few more negative cases.

> Provide a mechanism to represent complex filters and parse them at the REST layer 
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-4447
>                 URL: https://issues.apache.org/jira/browse/YARN-4447
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: Timeline-Filters.pdf, YARN-4447-YARN-2928.01.patch, YARN-4447-YARN-2928.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org