[GitHub] [lucene-solr] dweiss commented on a change in pull request #1364: SOLR-14335: Lock Solr's memory to prevent swapping

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #1364: SOLR-14335: Lock Solr's memory to prevent swapping
URL: https://github.com/apache/lucene-solr/pull/1364#discussion_r395134989
 
 

 ##########
 File path: solr/server/build.gradle
 ##########
 @@ -111,7 +112,12 @@ task assemblePackaging(type: Sync) {
     into "lib/ext"
   })
 
-  from { project.configurations.startJar.singleFile } {
+  from("${buildDir}/libs", {
 
 Review comment:
   This doesn't seem to be right. you rename twice into the same solr.jar. And I don't think it's elegant that the server depends on the launcher (jetty-start). It's a smell.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org