You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2017/05/01 19:59:17 UTC
Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-5937
https://issues.apache.org/jira/browse/MESOS-5937
Repository: mesos
Description
-------
This code was deprecated for Linux, and thus makes no sense
to port to Windows. This patch removes test from the Windows
platform completely.
Diffs
-----
3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e
3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d
Diff: https://reviews.apache.org/r/58889/diff/1/
Testing
-------
For Linux, all tests pass. In particular, with FlagsFileTest:
[----------] 2 tests from FlagsFileTest
[ RUN ] FlagsFileTest.JSONFile
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a command line option out of without using 'file:// is deprecated and will be removed in a future release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
[ OK ] FlagsFileTest.JSONFile (0 ms)
[ RUN ] FlagsFileTest.FilePrefix
[ OK ] FlagsFileTest.FilePrefix (0 ms)
[----------] 2 tests from FlagsFileTest (0 ms total)
For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, it's only appropriate for Linux. Thus, it's not run.
[----------] 2 tests from FlagsFileTest
[ RUN ] FlagsFileTest.JSONFile
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a command line option out of without using 'file:// is deprecated and will be removed in a future release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
[ OK ] FlagsFileTest.JSONFile (0 ms)
[ RUN ] FlagsFileTest.FilePrefix
[ OK ] FlagsFileTest.FilePrefix (0 ms)
[----------] 2 tests from FlagsFileTest (0 ms total)
Thanks,
Jeff Coffler
Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/#review173518
-----------------------------------------------------------
3rdparty/stout/include/stout/flags/parse.hpp
Lines 98 (patched)
<https://reviews.apache.org/r/58889/#comment246507>
s/Noate/NOTE:
- Andrew Schwartzmeyer
On May 1, 2017, 8 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58889/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 8 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-5937
> https://issues.apache.org/jira/browse/MESOS-5937
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This code was deprecated for Linux, and thus makes no sense
> to port to Windows. This patch removes test from the Windows
> platform completely.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e
> 3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d
>
>
> Diff: https://reviews.apache.org/r/58889/diff/1/
>
>
> Testing
> -------
>
> For Linux, all tests pass. In particular, with FlagsFileTest:
>
> [----------] 2 tests from FlagsFileTest
> [ RUN ] FlagsFileTest.JSONFile
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a command line option out of without using 'file:// is deprecated and will be removed in a future release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
> [ OK ] FlagsFileTest.JSONFile (0 ms)
> [ RUN ] FlagsFileTest.FilePrefix
> [ OK ] FlagsFileTest.FilePrefix (0 ms)
> [----------] 2 tests from FlagsFileTest (0 ms total)
>
> For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, it's only appropriate for Linux. Thus, it's not run.
>
> PS C:\mesos\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="FlagsFile*"
> Note: Google Test filter = FlagsFile*-
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from FlagsFileTest
> [ RUN ] FlagsFileTest.FilePrefix
> [ OK ] FlagsFileTest.FilePrefix (3 ms)
> [----------] 1 test from FlagsFileTest (3 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (7 ms total)
> [ PASSED ] 1 test.
> PS C:\mesos\mesos>
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/#review174990
-----------------------------------------------------------
Fix it, then Ship it!
I can fix this up before committing.
3rdparty/stout/include/stout/flags/parse.hpp
Lines 116-134 (original), 122-140 (patched)
<https://reviews.apache.org/r/58889/#comment248293>
This part for JSON::Arrays needs the same treatment.
3rdparty/stout/tests/flags_tests.cpp
Lines 1022 (patched)
<https://reviews.apache.org/r/58889/#comment248294>
`// __WINDOWS__`
- Joseph Wu
On May 2, 2017, noon, Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58889/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, noon)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-5937
> https://issues.apache.org/jira/browse/MESOS-5937
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This code was deprecated for Linux, and thus makes no sense
> to port to Windows. This patch removes test from the Windows
> platform completely.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e
> 3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d
>
>
> Diff: https://reviews.apache.org/r/58889/diff/2/
>
>
> Testing
> -------
>
> For Linux, all tests pass. In particular, with FlagsFileTest:
>
> [----------] 2 tests from FlagsFileTest
> [ RUN ] FlagsFileTest.JSONFile
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a command line option out of without using 'file:// is deprecated and will be removed in a future release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
> [ OK ] FlagsFileTest.JSONFile (0 ms)
> [ RUN ] FlagsFileTest.FilePrefix
> [ OK ] FlagsFileTest.FilePrefix (0 ms)
> [----------] 2 tests from FlagsFileTest (0 ms total)
>
> For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, it's only appropriate for Linux. Thus, it's not run.
>
> PS C:\mesos\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="FlagsFile*"
> Note: Google Test filter = FlagsFile*-
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from FlagsFileTest
> [ RUN ] FlagsFileTest.FilePrefix
> [ OK ] FlagsFileTest.FilePrefix (3 ms)
> [----------] 1 test from FlagsFileTest (3 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (7 ms total)
> [ PASSED ] 1 test.
> PS C:\mesos\mesos>
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/#review173699
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58673, 58889]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 2, 2017, 7 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58889/
> -----------------------------------------------------------
>
> (Updated May 2, 2017, 7 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-5937
> https://issues.apache.org/jira/browse/MESOS-5937
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This code was deprecated for Linux, and thus makes no sense
> to port to Windows. This patch removes test from the Windows
> platform completely.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e
> 3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d
>
>
> Diff: https://reviews.apache.org/r/58889/diff/2/
>
>
> Testing
> -------
>
> For Linux, all tests pass. In particular, with FlagsFileTest:
>
> [----------] 2 tests from FlagsFileTest
> [ RUN ] FlagsFileTest.JSONFile
> WARNING: Logging before InitGoogleLogging() is written to STDERR
> W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a command line option out of without using 'file:// is deprecated and will be removed in a future release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
> [ OK ] FlagsFileTest.JSONFile (0 ms)
> [ RUN ] FlagsFileTest.FilePrefix
> [ OK ] FlagsFileTest.FilePrefix (0 ms)
> [----------] 2 tests from FlagsFileTest (0 ms total)
>
> For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, it's only appropriate for Linux. Thus, it's not run.
>
> PS C:\mesos\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="FlagsFile*"
> Note: Google Test filter = FlagsFile*-
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from FlagsFileTest
> [ RUN ] FlagsFileTest.FilePrefix
> [ OK ] FlagsFileTest.FilePrefix (3 ms)
> [----------] 1 test from FlagsFileTest (3 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (7 ms total)
> [ PASSED ] 1 test.
> PS C:\mesos\mesos>
>
>
> Thanks,
>
> Jeff Coffler
>
>
Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/
-----------------------------------------------------------
(Updated May 2, 2017, 7 p.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Changes
-------
Fixed typo that Andy pointed out.
Bugs: MESOS-5937
https://issues.apache.org/jira/browse/MESOS-5937
Repository: mesos
Description
-------
This code was deprecated for Linux, and thus makes no sense
to port to Windows. This patch removes test from the Windows
platform completely.
Diffs (updated)
-----
3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e
3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d
Diff: https://reviews.apache.org/r/58889/diff/2/
Changes: https://reviews.apache.org/r/58889/diff/1-2/
Testing
-------
For Linux, all tests pass. In particular, with FlagsFileTest:
[----------] 2 tests from FlagsFileTest
[ RUN ] FlagsFileTest.JSONFile
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a command line option out of without using 'file:// is deprecated and will be removed in a future release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
[ OK ] FlagsFileTest.JSONFile (0 ms)
[ RUN ] FlagsFileTest.FilePrefix
[ OK ] FlagsFileTest.FilePrefix (0 ms)
[----------] 2 tests from FlagsFileTest (0 ms total)
For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, it's only appropriate for Linux. Thus, it's not run.
PS C:\mesos\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="FlagsFile*"
Note: Google Test filter = FlagsFile*-
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FlagsFileTest
[ RUN ] FlagsFileTest.FilePrefix
[ OK ] FlagsFileTest.FilePrefix (3 ms)
[----------] 1 test from FlagsFileTest (3 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (7 ms total)
[ PASSED ] 1 test.
PS C:\mesos\mesos>
Thanks,
Jeff Coffler
Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58889/
-----------------------------------------------------------
(Updated May 1, 2017, 8 p.m.)
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-5937
https://issues.apache.org/jira/browse/MESOS-5937
Repository: mesos
Description
-------
This code was deprecated for Linux, and thus makes no sense
to port to Windows. This patch removes test from the Windows
platform completely.
Diffs
-----
3rdparty/stout/include/stout/flags/parse.hpp 65edd86372596c2107e9f29cf27301e025e6620e
3rdparty/stout/tests/flags_tests.cpp e2681f8f68f6478d4c8a20c1e75ddb050d16b56d
Diff: https://reviews.apache.org/r/58889/diff/1/
Testing (updated)
-------
For Linux, all tests pass. In particular, with FlagsFileTest:
[----------] 2 tests from FlagsFileTest
[ RUN ] FlagsFileTest.JSONFile
WARNING: Logging before InitGoogleLogging() is written to STDERR
W0501 12:55:43.343416 38425 parse.hpp:101] Specifying an absolute filename to read a command line option out of without using 'file:// is deprecated and will be removed in a future release. Simply adding 'file://' to the beginning of the path should eliminate this warning.
[ OK ] FlagsFileTest.JSONFile (0 ms)
[ RUN ] FlagsFileTest.FilePrefix
[ OK ] FlagsFileTest.FilePrefix (0 ms)
[----------] 2 tests from FlagsFileTest (0 ms total)
For Windows, where FlagsFileTest.JSONFile is testing deprecated behavior, it's only appropriate for Linux. Thus, it's not run.
PS C:\mesos\mesos> .\build\3rdparty\stout\tests\Debug\stout-tests.exe --gtest_filter="FlagsFile*"
Note: Google Test filter = FlagsFile*-
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FlagsFileTest
[ RUN ] FlagsFileTest.FilePrefix
[ OK ] FlagsFileTest.FilePrefix (3 ms)
[----------] 1 test from FlagsFileTest (3 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (7 ms total)
[ PASSED ] 1 test.
PS C:\mesos\mesos>
Thanks,
Jeff Coffler