[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5971: libc: Avoid the compiler generate code call self(memcpy/memmove/memset/memcmp) recursively

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #5971:
URL: https://github.com/apache/incubator-nuttx/pull/5971#discussion_r841500472


##########
libs/libc/string/lib_strcat.c:
##########
@@ -34,9 +34,9 @@
 #undef strcat /* See mm/README.txt */
 char *strcat(char *dest, const char *src)
 {
-  char *ret   = dest;
+  char *ret = dest;

Review Comment:
   ```suggestion
     FAR char *ret = dest;
   ```



##########
libs/libc/string/lib_strcat.c:
##########
@@ -34,9 +34,9 @@
 #undef strcat /* See mm/README.txt */
 char *strcat(char *dest, const char *src)

Review Comment:
   ```suggestion
   char *strcat(FAR char *dest, FAR const char *src)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org