[GitHub] [ignite] map7000 commented on a change in pull request #8971: IGNITE-13605 PDS compatibility for ignite versions

[GitBox <gi...@apache.org>]

map7000 commented on a change in pull request #8971:
URL: https://github.com/apache/ignite/pull/8971#discussion_r607188220



##########
File path: modules/ducktests/tests/ignitetest/tests/compatibility/pds_compatibility_test.py
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+This module contains test that checks that PDS "from_version" compatible with "to_version"
+"""
+from ducktape.mark import parametrize
+
+from ignitetest.services.ignite import IgniteService
+from ignitetest.services.ignite_app import IgniteApplicationService
+from ignitetest.services.utils.control_utility import ControlUtility
+from ignitetest.services.utils.ignite_configuration.discovery import from_ignite_cluster
+from ignitetest.services.utils.ignite_configuration import IgniteConfiguration, DataStorageConfiguration
+from ignitetest.services.utils.ignite_configuration.data_storage import DataRegionConfiguration
+from ignitetest.utils import cluster
+from ignitetest.utils.ignite_test import IgniteTest
+from ignitetest.utils.version import DEV_BRANCH, LATEST, IgniteVersion
+
+
+# pylint: disable=W0223
+# pylint: disable=no-member
+class PdsCompatibilityTest(IgniteTest):
+    """
+    A simple test to check PDS compatibility of different Ignite versions
+
+    Start Ignite cluster version "from_version" with PDS enabled
+    Start a client application that puts prepared data looks like
+    User (1, "John Connor")
+    User (2, "Sarah Connor")
+    User (3, "Kyle Reese")
+    Stop cluster and client
+    Start Ignite cluster version "to_version" without PDS clearing
+    Start client that reads data and checks that it can be read and have not changed
+
+    """
+    APP_CLASS = "org.apache.ignite.internal.ducktest.tests.compatibility.PdsCompatiblityApplication"
+    LOAD_OPERATION = "load"
+    CHECK_OPERATION = "check"
+
+    @cluster(num_nodes=3)
+    @parametrize(version_from=str(LATEST), version_to=str(DEV_BRANCH))
+    def test_pds_compatibility(self, version_from, version_to):
+        """
+        Saves data using one version of ignite and then load with another.
+        """
+
+        num_nodes = len(self.test_context.cluster) - 2
+
+        server_configuration_from = IgniteConfiguration(version=IgniteVersion(version_from),
+                                                        data_storage=DataStorageConfiguration(
+                                                            default=DataRegionConfiguration(persistent=True)))
+
+        server_configuration_to = server_configuration_from._replace(version=IgniteVersion(version_to))
+
+        ignite_from = IgniteService(self.test_context, server_configuration_from, num_nodes=num_nodes)
+        nodes = ignite_from.nodes.copy()
+
+        ignite_from.start()
+
+        self._run_application(ignite_from, self.LOAD_OPERATION)
+
+        ignite_from.stop()
+        ignite_from.free()
+
+        ignite_to = IgniteService(self.test_context, server_configuration_to, num_nodes=num_nodes)
+        ignite_to.nodes = nodes
+        ignite_to.start(clean=False)
+
+        self._run_application(ignite_to, self.CHECK_OPERATION)
+
+    def _run_application(self, ignite, operation):
+        control_utility = ControlUtility(ignite)
+        control_utility.activate()
+
+        app_config = ignite.config._replace(client_mode=True, discovery_spi=from_ignite_cluster(ignite))
+        app = IgniteApplicationService(self.test_context, config=app_config,
+                                       java_class_name=self.APP_CLASS,
+                                       params={"operation": operation})
+        app.start()
+        app.await_stopped()
+        control_utility.deactivate()

Review comment:
       We stop cluster using kill command. 
   I don't know that kind of side-effects it can bring us
   It's safe to deactivate first




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org