You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/14 04:23:08 UTC
[GitHub] [spark] HyukjinKwon commented on pull request #41767: [SPARK-44222][BUILD][PYTHON] Upgrade `grpc` to 1.56.0
HyukjinKwon commented on PR #41767:
URL: https://github.com/apache/spark/pull/41767#issuecomment-1635248255
Hmmm .. seems like this actually brings some problem to Spark Connect dev. e.g.,:
```
The conflict is caused by:
The user requested protobuf==3.19.5
grpcio-status 1.56.0 depends on protobuf>=4.21.6
```
But we specify protobuf:
https://github.com/apache/spark/blob/master/dev/requirements.txt#L55
that is only used for dev.
We can't easily upgrade protobuf otherwise it will change the generated codes, and we should take a closer look for compatibility at https://github.com/apache/spark/tree/master/python/pyspark/sql/connect/proto because it requires a major version bumpup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org