[GitHub] [shardingsphere-elasticjob] zhaojinchao95 commented on a diff in pull request #2124: fix issue[2122] use unbounded thread pool to avoid watch lost

[GitBox <gi...@apache.org>]

zhaojinchao95 commented on code in PR #2124:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2124#discussion_r991787030


##########
elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/integrate/BaseIntegrateTest.java:
##########
@@ -92,7 +90,7 @@ public void setUp() {
     @After
     public void tearDown() {
         jobBootstrap.shutdown();
-        ReflectionUtils.setFieldValue(JobRegistry.getInstance(), "instance", null);
+        // ReflectionUtils.setFieldValue(JobRegistry.getInstance(), "instance", null);

Review Comment:
   @xlcn Hi, why adjustment here?
   



##########
elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/integrate/enable/EnabledJobIntegrateTest.java:
##########
@@ -54,7 +54,7 @@ public final void assertEnabledRegCenterInfo() {
         assertThat(getREGISTRY_CENTER().get("/" + getJobName() + "/servers/" + JobRegistry.getInstance().getJobInstance(getJobName()).getServerIp()), is(ServerStatus.ENABLED.name()));
         assertThat(getREGISTRY_CENTER().get("/" + getJobName() + "/leader/election/instance"), is(JobRegistry.getInstance().getJobInstance(getJobName()).getJobInstanceId()));
         assertTrue(getREGISTRY_CENTER().isExisted("/" + getJobName() + "/instances/" + JobRegistry.getInstance().getJobInstance(getJobName()).getJobInstanceId()));
-        getREGISTRY_CENTER().remove("/" + getJobName() + "/leader/election");
-        assertTrue(getLeaderService().isLeaderUntilBlock());
+        // getREGISTRY_CENTER().remove("/" + getJobName() + "/leader/election");
+        // assertTrue(getLeaderService().isLeaderUntilBlock());

Review Comment:
   @xlcn Hi, why adjustment here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org