You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ChugR <gi...@git.apache.org> on 2018/08/09 19:13:40 UTC
[GitHub] qpid-dispatch pull request #355: DISPATCH-1098: Adjust name of unit2 executa...
GitHub user ChugR opened a pull request:
https://github.com/apache/qpid-dispatch/pull/355
DISPATCH-1098: Adjust name of unit2 executable for python3
CMake chooses between 'python' and 'python3'.
Make a similar choice for 'unit2' and 'unit2-3'.
This lets both python2 and python3 versions to be installed on a system and chooses between them based on the result of PYTHON_VERSING_MAJOR.
Tested on Fedora only.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChugR/qpid-dispatch DISPATCH-1098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit fdefed692a8c5a520aebcb0f16551ac0ee92858e
Author: Chuck Rolke <cr...@...>
Date: 2018-08-09T19:00:34Z
DISPATCH-1098: Adjust name of unit2 executable for python3
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #355: DISPATCH-1098: Adjust name of unit2 executable for...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/355
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=h1) Report
> Merging [#355](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/ba87373735d69fe28e8c77169b5a4e5b9bf278f5?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
- Coverage 84.48% 84.47% -0.01%
==========================================
Files 69 69
Lines 15730 15730
==========================================
- Hits 13289 13288 -1
- Misses 2441 2442 +1
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `98.89% <0%> (-0.37%)` | :arrow_down: |
| [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `86.6% <0%> (-0.23%)` | :arrow_down: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.55% <0%> (-0.2%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.31% <0%> (+0.11%)` | :arrow_up: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/355/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.51% <0%> (+0.13%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=footer). Last update [ba87373...fdefed6](https://codecov.io/gh/apache/qpid-dispatch/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #355: DISPATCH-1098: Adjust name of unit2 executa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/355
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org