You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/23 11:25:55 UTC
[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request
#1543: Refactor login verification process
elonlo opened a new pull request #1543: Refactor login verification process
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543
## What is the purpose of the pull request
Refactor login authentication process, use interface
## Brief change log
- *AuthenticationType file to dolphinscheduler-api module*
- *Add AuthenticationType file to dolphinscheduler-api module*
- *Add Authenticator file to dolphinscheduler-api module*
- *Add SecurityConfig file to dolphinscheduler-api module*
- *Add PasswordAuthenticator file to dolphinscheduler-api module*
- *Add LoginHandlerInterceptorTest file to dolphinscheduler-api module*
- *Add SecurityConfigTest file to dolphinscheduler-api module*
- *Add PasswordAuthenticatorTest file to dolphinscheduler-api module*
- *Modify LoginHandlerInterceptor file*
- *Modify LoginController file*
- *Modify TenantService file*
- *Modify UsersService file*
## Verify this pull request
This change added tests and can be verified as follows:
- *Added PasswordAuthenticatorTest to verify password authenticator.*
- *Added LoginHandlerInterceptorTest to verify interceptor.*
- *Add SecurityConfigTest to verify authenticator is available.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1543: Refactor login verification process
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1543: Refactor login verification process
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=h1) Report
> Merging [#1543](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d44d06489ad16ae735067ada030ff45cfe1b6dc0?src=pr&el=desc) will **increase** coverage by `0.72%`.
> The diff coverage is `33.82%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1543 +/- ##
========================================
+ Coverage 7.76% 8.49% +0.72%
========================================
Files 272 275 +3
Lines 13641 13684 +43
Branches 2166 2171 +5
========================================
+ Hits 1059 1162 +103
+ Misses 12511 12446 -65
- Partials 71 76 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `0.87% <0%> (+0.87%)` | :arrow_up: |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `0.36% <0%> (+0.36%)` | :arrow_up: |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `3.33% <0%> (+3.33%)` | :arrow_up: |
| [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `66.66% <100%> (+66.66%)` | :arrow_up: |
| [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100% <100%> (ø)` | |
| [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `50% <50%> (ø)` | |
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `64.28% <64.28%> (ø)` | |
| ... and [42 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=footer). Last update [d44d064...d079c50](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1543: Refactor login verification process
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1543: Refactor login verification process
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=h1) Report
> Merging [#1543](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d44d06489ad16ae735067ada030ff45cfe1b6dc0?src=pr&el=desc) will **increase** coverage by `0.72%`.
> The diff coverage is `33.82%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1543 +/- ##
========================================
+ Coverage 7.76% 8.49% +0.72%
========================================
Files 272 275 +3
Lines 13641 13684 +43
Branches 2166 2171 +5
========================================
+ Hits 1059 1162 +103
+ Misses 12511 12446 -65
- Partials 71 76 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `0.87% <0%> (+0.87%)` | :arrow_up: |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `0.36% <0%> (+0.36%)` | :arrow_up: |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `3.33% <0%> (+3.33%)` | :arrow_up: |
| [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `66.66% <100%> (+66.66%)` | :arrow_up: |
| [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100% <100%> (ø)` | |
| [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `50% <50%> (ø)` | |
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `64.28% <64.28%> (ø)` | |
| ... and [42 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=footer). Last update [d44d064...04823c2](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1543:
Refactor login verification process
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #1543: Refactor login verification process
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1543:
Refactor login verification process
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1543: Refactor login verification process
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=h1) Report
> Merging [#1543](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d44d06489ad16ae735067ada030ff45cfe1b6dc0?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1543 +/- ##
========================================
- Coverage 7.76% 7.72% -0.04%
========================================
Files 272 275 +3
Lines 13641 13684 +43
Branches 2166 2171 +5
========================================
- Hits 1059 1057 -2
- Misses 12511 12556 +45
Partials 71 71
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `0% <0%> (ø)` | |
| [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `0% <0%> (ø)` | |
| [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `0% <0%> (ø)` | |
| [...ache/dolphinscheduler/common/enums/ZKNodeType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1pLTm9kZVR5cGUuamF2YQ==) | `0% <0%> (-100%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=footer). Last update [d44d064...04823c2](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services