You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Scott Chen (Created) (JIRA)" <ji...@apache.org> on 2012/03/02 07:15:00 UTC
[jira] [Created] (THRIFT-1531) Framed transport does not work with
binary protocol in some case
Framed transport does not work with binary protocol in some case
----------------------------------------------------------------
Key: THRIFT-1531
URL: https://issues.apache.org/jira/browse/THRIFT-1531
Project: Thrift
Issue Type: Bug
Reporter: Scott Chen
We are seeing that in some case. If you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
https://issues.apache.org/jira/browse/HBASE-5507
It can be reproduced by the unit test added in
https://issues.apache.org/jira/browse/HBASE-5506
Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1531) Framed transport does not work
with binary protocol in some case
Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221684#comment-13221684 ]
Scott Chen commented on THRIFT-1531:
------------------------------------
Bryan: You are right! That's exactly the reason. Thanks!
https://reviews.facebook.net/D2073
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1531) Framed transport does not work
with binary protocol in some case
Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221211#comment-13221211 ]
Scott Chen commented on THRIFT-1531:
------------------------------------
Yes, if we use framed and compact the problem no loner occur.
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1531) Framed transport does not work with
binary protocol in some case
Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated THRIFT-1531:
-------------------------------
Description:
We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
https://issues.apache.org/jira/browse/HBASE-5507
It can be reproduced by the unit test added in
https://issues.apache.org/jira/browse/HBASE-5506
Our server is a java server.
was:
We are seeing that in some case. If you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
https://issues.apache.org/jira/browse/HBASE-5507
It can be reproduced by the unit test added in
https://issues.apache.org/jira/browse/HBASE-5506
Our server is a java server.
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1531) Framed transport does not work
with binary protocol in some case
Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220715#comment-13220715 ]
dhruba borthakur commented on THRIFT-1531:
------------------------------------------
also, is it true that if you use compact=true, then the problem does not occur?
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1531) Framed transport does not work
with binary protocol in some case
Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221680#comment-13221680 ]
Scott Chen commented on THRIFT-1531:
------------------------------------
Bryan: Thanks! I think that may be possible. I will check.
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1531) Framed transport does not work with
binary protocol in some case
Posted by "Scott Chen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen resolved THRIFT-1531.
--------------------------------
Resolution: Invalid
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1531) Framed transport does not work
with binary protocol in some case
Posted by "Bryan Duxbury (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221299#comment-13221299 ]
Bryan Duxbury commented on THRIFT-1531:
---------------------------------------
I had a cursory look at the patch on HBASE-5506. Is there any chance you're using the .array() method of the binary argument without regard for .arrayOffset(), .position(), or .length()? This would lead to you seeing the entire Thrift message that was sent, including frame size and message header.
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1531) Framed transport does not work with
binary protocol in some case
Posted by "Scott Chen (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen closed THRIFT-1531.
------------------------------
Assignee: Bryan Duxbury
> Framed transport does not work with binary protocol in some case
> ----------------------------------------------------------------
>
> Key: THRIFT-1531
> URL: https://issues.apache.org/jira/browse/THRIFT-1531
> Project: Thrift
> Issue Type: Bug
> Reporter: Scott Chen
> Assignee: Bryan Duxbury
>
> We are seeing that in some case if you use framed transport and binary protocol, the parameter passed to the server side will be corrupted.
> https://issues.apache.org/jira/browse/HBASE-5507
> It can be reproduced by the unit test added in
> https://issues.apache.org/jira/browse/HBASE-5506
> Our server is a java server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira