You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/17 10:58:36 UTC
[GitHub] [skywalking] xuanyu66 opened a new pull request #6567: fix no trace id in async log
xuanyu66 opened a new pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [X] Explain briefly why the bug exists and how to fix it. #6566 6566
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597770395
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
You can see CreateMementoInstrumentation, which propagates the context through copy/paste the dynamic field.
AsyncAppenderInstrumentation isn't written by me, I just modify it.
> This is about setting the current trace id to a new object's dynamic
the AsyncAppenderInstrumentation and AsyncLoggerConfigInstrumentation is not added by me. I don't why do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `16.56%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 52.89% +16.56%
- Complexity 2178 3959 +1781
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13525 +6242
+ Misses 12222 10892 -1330
- Partials 542 1154 +612
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `51.78% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [456 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.62%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 53.95% +17.62%
- Complexity 2178 4023 +1845
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13797 +6514
+ Misses 12222 10593 -1629
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...pm/agent/core/context/SW8ExtensionCarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhFeHRlbnNpb25DYXJyaWVySXRlbS5qYXZh) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...sticsearch7/StorageModuleElasticsearch7Config.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdDb25maWcuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...plugin/elasticsearch7/base/IndexEs7Structures.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9iYXNlL0luZGV4RXM3U3RydWN0dXJlcy5qYXZh) | `100.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `76.92% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `80.95% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| ... and [467 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 184 -628
Lines 20047 4512 -15535
Branches 1908 515 -1393
============================================
- Hits 7283 0 -7283
+ Misses 12222 4512 -7710
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [962 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `11.64%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 41.80% -11.65%
+ Complexity 4110 3064 -1046
=============================================
Files 1790 979 -811
Lines 38329 24011 -14318
Branches 4219 2347 -1872
=============================================
- Hits 20487 10037 -10450
+ Misses 16857 13120 -3737
+ Partials 985 854 -131
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `23.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 29.61% -23.84%
+ Complexity 4110 2273 -1837
=============================================
Files 1790 1011 -779
Lines 38329 24980 -13349
Branches 4219 2433 -1786
=============================================
- Hits 20487 7397 -13090
- Misses 16857 17006 +149
+ Partials 985 577 -408
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1415 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597772042
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
So, you mean there is an override that happens here? So you add `==null` to avoid that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `7.43%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 28.89% -7.44%
+ Complexity 2178 2082 -96
============================================
Files 812 982 +170
Lines 20047 24104 +4057
Branches 1908 2356 +448
============================================
- Hits 7283 6965 -318
- Misses 12222 16614 +4392
+ Partials 542 525 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/analyzer/provider/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=) | `4.16% <0.00%> (-93.75%)` | `2.00% <0.00%> (-15.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [229 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.12% +17.79%
- Complexity 2178 4032 +1854
=============================================
Files 812 1031 +219
Lines 20047 25582 +5535
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10554 -1668
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `80.95% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `51.78% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `67.79% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
| ... and [472 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 39.81% +3.48%
- Complexity 2178 2849 +671
============================================
Files 812 1012 +200
Lines 20047 25083 +5036
Branches 1908 2440 +532
============================================
+ Hits 7283 9986 +2703
- Misses 12222 14306 +2084
- Partials 542 791 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [.../agent/core/context/ids/NewDistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvTmV3RGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **increase** coverage by `2.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 53.45% 55.55% +2.10%
+ Complexity 4110 4091 -19
============================================
Files 1790 1033 -757
Lines 38329 25635 -12694
Branches 4219 2508 -1711
============================================
- Hits 20487 14242 -6245
+ Misses 16857 10187 -6670
- Partials 985 1206 +221
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `5.64%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 30.68% -5.65%
- Complexity 2178 2209 +31
============================================
Files 812 982 +170
Lines 20047 24160 +4113
Branches 1908 2361 +453
============================================
+ Hits 7283 7413 +130
- Misses 12222 16204 +3982
- Partials 542 543 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `69.86% <0.00%> (-2.74%)` | `13.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [185 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `11.17%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 36.32% 25.15% -11.18%
+ Complexity 2178 1824 -354
=============================================
Files 812 1001 +189
Lines 20047 24116 +4069
Branches 1908 2339 +431
=============================================
- Hits 7283 6066 -1217
- Misses 12222 17623 +5401
+ Partials 542 427 -115
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ng/oap/meter/analyzer/dsl/SampleFamilyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [293 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 187 -625
Lines 20047 4619 -15428
Branches 1908 523 -1385
============================================
- Hits 7283 0 -7283
+ Misses 12222 4619 -7603
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [965 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 180 -632
Lines 20047 4430 -15617
Branches 1908 497 -1411
============================================
- Hits 7283 0 -7283
+ Misses 12222 4430 -7792
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [958 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597773719
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
@EvanLjp Could you take a look at whether this is in use if you activated the async appender?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.78%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.11% +17.78%
- Complexity 2178 4032 +1854
=============================================
Files 812 1032 +220
Lines 20047 25586 +5539
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10558 -1664
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `51.78% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...agent/core/boot/AgentPackageNotFoundException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9BZ2VudFBhY2thZ2VOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [473 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803802088
@wu-sheng I found an unused field, going to remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `5.92%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 42.25% +5.92%
- Complexity 2178 3052 +874
============================================
Files 812 979 +167
Lines 20047 23892 +3845
Branches 1908 2309 +401
============================================
+ Hits 7283 10095 +2812
- Misses 12222 12941 +719
- Partials 542 856 +314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...erver/storage/plugin/jdbc/h2/dao/H2StorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyU3RvcmFnZURBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/storage/plugin/jdbc/h2/dao/H2RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUmVjb3JkREFPLmphdmE=) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ing/oap/server/storage/plugin/jdbc/SQLBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-92.31%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] J-Cod3r commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
J-Cod3r commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803726961
I see, you have a mix of `AsyncAppender` and `AsyncLogger` in your scenario, @wu-sheng I have no question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `53.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 0.00% -53.46%
============================================
Files 1790 186 -1604
Lines 38329 4547 -33782
Branches 4219 506 -3713
============================================
- Hits 20487 0 -20487
+ Misses 16857 4547 -12310
+ Partials 985 0 -985
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1768 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `53.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 0.00% -53.46%
============================================
Files 1790 182 -1608
Lines 38329 4482 -33847
Branches 4219 498 -3721
============================================
- Hits 20487 0 -20487
+ Misses 16857 4482 -12375
+ Partials 985 0 -985
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1768 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `12.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 41.12% -12.33%
+ Complexity 4110 3016 -1094
=============================================
Files 1790 979 -811
Lines 38329 24011 -14318
Branches 4219 2347 -1872
=============================================
- Hits 20487 9875 -10612
+ Misses 16857 13297 -3560
+ Partials 985 839 -146
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1353 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r595983742
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
I have the same problem as Sheng? @xuanyu66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 186 -626
Lines 20047 4523 -15524
Branches 1908 515 -1393
============================================
- Hits 7283 0 -7283
+ Misses 12222 4523 -7699
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [964 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.78%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.11% +17.78%
- Complexity 2178 4032 +1854
=============================================
Files 812 1032 +220
Lines 20047 25586 +5539
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10558 -1664
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...p/server/receiver/zipkin/ZipkinReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJNb2R1bGUuamF2YQ==) | `66.66% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `21.42% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `83.78% <0.00%> (ø)` | `9.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `75.92% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| ... and [473 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `12.74%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 40.70% -12.75%
+ Complexity 4110 2997 -1113
=============================================
Files 1790 978 -812
Lines 38329 24004 -14325
Branches 4219 2347 -1872
=============================================
- Hits 20487 9772 -10715
+ Misses 16857 13392 -3465
+ Partials 985 840 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 189 -623
Lines 20047 4540 -15507
Branches 1908 515 -1393
============================================
- Hits 7283 0 -7283
+ Misses 12222 4540 -7682
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [967 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `13.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 49.54% +13.21%
- Complexity 2178 3626 +1448
=============================================
Files 812 1011 +199
Lines 20047 25014 +4967
Branches 1908 2433 +525
=============================================
+ Hits 7283 12392 +5109
+ Misses 12222 11546 -676
- Partials 542 1076 +534
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `46.42% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `13.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 49.57% +13.24%
- Complexity 2178 3628 +1450
=============================================
Files 812 1011 +199
Lines 20047 25014 +4967
Branches 1908 2433 +525
=============================================
+ Hits 7283 12401 +5118
+ Misses 12222 11536 -686
- Partials 542 1077 +535
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/plugin/PluginBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkJvb3RzdHJhcC5qYXZh) | `74.07% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r598073831
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/CreateMementoInterceptor.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.log4j.v2.x.async;
+
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor;
+
+import java.lang.reflect.Method;
+
+public class CreateMementoInterceptor implements StaticMethodsAroundInterceptor {
+
+ private String tag;
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `12.55%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 40.89% -12.56%
+ Complexity 4110 2997 -1113
=============================================
Files 1790 973 -817
Lines 38329 23893 -14436
Branches 4219 2328 -1891
=============================================
- Hits 20487 9772 -10715
+ Misses 16857 13281 -3576
+ Partials 985 840 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `16.93%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 53.26% +16.93%
- Complexity 2178 3943 +1765
=============================================
Files 812 1032 +220
Lines 20047 25495 +5448
Branches 1908 2496 +588
=============================================
+ Hits 7283 13579 +6296
+ Misses 12222 10776 -1446
- Partials 542 1140 +598
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [464 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `1.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 38.12% +1.79%
- Complexity 2178 2859 +681
============================================
Files 812 1001 +189
Lines 20047 24313 +4266
Branches 1908 2381 +473
============================================
+ Hits 7283 9270 +1987
- Misses 12222 14235 +2013
- Partials 542 808 +266
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/analyzer/provider/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=) | `4.16% <0.00%> (-93.75%)` | `2.00% <0.00%> (-15.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/analyzer/event/EventAnalyzerServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXJTZXJ2aWNlSW1wbC5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [258 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 39.85% +3.52%
- Complexity 2178 2855 +677
============================================
Files 812 1012 +200
Lines 20047 25083 +5036
Branches 1908 2440 +532
============================================
+ Hits 7283 9996 +2713
- Misses 12222 14296 +2074
- Partials 542 791 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `3.57% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `13.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 40.30% -13.15%
+ Complexity 4110 2974 -1136
=============================================
Files 1790 1012 -778
Lines 38329 25195 -13134
Branches 4219 2453 -1766
=============================================
- Hits 20487 10156 -10331
+ Misses 16857 14275 -2582
+ Partials 985 764 -221
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1327 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **increase** coverage by `0.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 53.45% 53.99% +0.54%
+ Complexity 4110 4013 -97
============================================
Files 1790 1031 -759
Lines 38329 25629 -12700
Branches 4219 2508 -1711
============================================
- Hits 20487 13839 -6648
+ Misses 16857 10616 -6241
- Partials 985 1174 +189
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1251 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597382418
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
> If this is the case, why don't you enhance createMemento to copy this new
@wu-sheng But I did enhance createMemento to copy this new field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 53.35% +17.02%
- Complexity 2178 3991 +1813
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13644 +6361
+ Misses 12222 10756 -1466
- Partials 542 1171 +629
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `80.95% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `51.78% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [464 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **increase** coverage by `1.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 53.45% 54.91% +1.46%
+ Complexity 4110 4048 -62
============================================
Files 1790 1031 -759
Lines 38329 25629 -12700
Branches 4219 2508 -1711
============================================
- Hits 20487 14075 -6412
+ Misses 16857 10364 -6493
- Partials 985 1190 +205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1246 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `11.41%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 42.03% -11.42%
+ Complexity 4110 3043 -1067
=============================================
Files 1790 1012 -778
Lines 38329 25195 -13134
Branches 4219 2453 -1766
=============================================
- Hits 20487 10591 -9896
+ Misses 16857 13788 -3069
+ Partials 985 816 -169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1328 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `5.83%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 42.16% +5.83%
- Complexity 2178 3118 +940
============================================
Files 812 982 +170
Lines 20047 24198 +4151
Branches 1908 2366 +458
============================================
+ Hits 7283 10203 +2920
- Misses 12222 13146 +924
- Partials 542 849 +307
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `77.77% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `56.52% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [.../status/AnnotationMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvQW5ub3RhdGlvbk1hdGNoRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `66.66% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| ... and [242 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `53.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 0.00% -53.46%
============================================
Files 1790 181 -1609
Lines 38329 4443 -33886
Branches 4219 497 -3722
============================================
- Hits 20487 0 -20487
+ Misses 16857 4443 -12414
+ Partials 985 0 -985
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1767 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `5.72%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 47.72% -5.73%
+ Complexity 4110 3553 -557
============================================
Files 1790 1012 -778
Lines 38329 25036 -13293
Branches 4219 2450 -1769
============================================
- Hits 20487 11948 -8539
+ Misses 16857 12058 -4799
- Partials 985 1030 +45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1297 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `16.69%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 53.02% +16.69%
- Complexity 2178 3963 +1785
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13558 +6275
+ Misses 12222 10849 -1373
- Partials 542 1164 +622
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...plugin/elasticsearch7/base/IndexEs7Structures.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9iYXNlL0luZGV4RXM3U3RydWN0dXJlcy5qYXZh) | `100.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...gent/core/plugin/interceptor/EnhanceException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL0VuaGFuY2VFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <0.00%> (ø)` | `9.00% <0.00%> (?%)` | |
| [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `46.29% <0.00%> (ø)` | `16.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `76.92% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| ... and [456 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 177 -635
Lines 20047 4339 -15708
Branches 1908 486 -1422
============================================
- Hits 7283 0 -7283
+ Misses 12222 4339 -7883
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [955 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 174 -638
Lines 20047 4310 -15737
Branches 1908 485 -1423
============================================
- Hits 7283 0 -7283
+ Misses 12222 4310 -7912
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [952 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `16.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 36.89% -16.56%
+ Complexity 4110 2748 -1362
=============================================
Files 1790 1012 -778
Lines 38329 25163 -13166
Branches 4219 2448 -1771
=============================================
- Hits 20487 9284 -11203
+ Misses 16857 15161 -1696
+ Partials 985 718 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1351 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `11.72%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 48.05% +11.72%
- Complexity 2178 3468 +1290
=============================================
Files 812 982 +170
Lines 20047 24321 +4274
Branches 1908 2374 +466
=============================================
+ Hits 7283 11688 +4405
+ Misses 12222 11648 -574
- Partials 542 985 +443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==) | `60.22% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `67.79% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [.../status/AnnotationMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvQW5ub3RhdGlvbk1hdGNoRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `66.66% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...e/skywalking/apm/agent/core/jvm/gc/GCProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL0dDUHJvdmlkZXIuamF2YQ==) | `45.83% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...apm/agent/core/jvm/cpu/NoSupportedCPUAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9Ob1N1cHBvcnRlZENQVUFjY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `76.92% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 188 -624
Lines 20047 4535 -15512
Branches 1908 515 -1393
============================================
- Hits 7283 0 -7283
+ Misses 12222 4535 -7687
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [966 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `13.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 49.54% +13.21%
- Complexity 2178 3626 +1448
=============================================
Files 812 1011 +199
Lines 20047 25014 +4967
Branches 1908 2433 +525
=============================================
+ Hits 7283 12392 +5109
+ Misses 12222 11546 -676
- Partials 542 1076 +534
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==) | `60.22% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `0.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 35.50% -0.83%
- Complexity 2178 2590 +412
============================================
Files 812 1011 +199
Lines 20047 25025 +4978
Branches 1908 2439 +531
============================================
+ Hits 7283 8886 +1603
- Misses 12222 15456 +3234
- Partials 542 683 +141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [.../agent/core/context/ids/NewDistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvTmV3RGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r596763629
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
In our scenario , We remove AsyncAppenderInstrumentation and AsyncLoggerConfigInstrumentation, and the plugin works well.
But if I remove them in open source code, I'am not sure it will break others' code.
So I decide to keep the code, and make it compatible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `4.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 40.33% +4.00%
- Complexity 2178 3013 +835
============================================
Files 812 1001 +189
Lines 20047 24371 +4324
Branches 1908 2390 +482
============================================
+ Hits 7283 9830 +2547
- Misses 12222 13707 +1485
- Partials 542 834 +292
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [248 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `15.13%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 51.46% +15.13%
- Complexity 2178 3763 +1585
=============================================
Files 812 998 +186
Lines 20047 24667 +4620
Branches 1908 2415 +507
=============================================
+ Hits 7283 12695 +5412
+ Misses 12222 10891 -1331
- Partials 542 1081 +539
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `21.42% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `72.97% <0.00%> (ø)` | `9.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `46.29% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...t/core/logging/core/converters/ClassConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQ2xhc3NDb252ZXJ0ZXIuamF2YQ==) | `66.66% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [406 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `10.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 46.59% +10.26%
- Complexity 2178 3407 +1229
=============================================
Files 812 1011 +199
Lines 20047 24861 +4814
Branches 1908 2402 +494
=============================================
+ Hits 7283 11583 +4300
- Misses 12222 12286 +64
- Partials 542 992 +450
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-8.00%)` | |
| [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (-1.00%)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.73%)` | `2.00% <0.00%> (-19.00%)` | |
| [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-84.00%)` | `0.00% <0.00%> (-22.00%)` | |
| [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [381 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `11.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 47.52% +11.19%
- Complexity 2178 3469 +1291
=============================================
Files 812 998 +186
Lines 20047 24596 +4549
Branches 1908 2407 +499
=============================================
+ Hits 7283 11689 +4406
+ Misses 12222 11923 -299
- Partials 542 984 +442
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...pm/agent/core/context/SW8ExtensionCarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhFeHRlbnNpb25DYXJyaWVySXRlbS5qYXZh) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `76.92% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `80.95% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `21.42% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `14.39%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 50.72% +14.39%
- Complexity 2178 3838 +1660
=============================================
Files 812 1029 +217
Lines 20047 25570 +5523
Branches 1908 2503 +595
=============================================
+ Hits 7283 12970 +5687
+ Misses 12222 11497 -725
- Partials 542 1103 +561
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `77.77% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...arch/ZipkinStorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `37.50% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...g/oap/server/storage/plugin/zipkin/ZipkinSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW4uamF2YQ==) | `75.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [439 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `0.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 52.77% -0.68%
+ Complexity 4110 3958 -152
============================================
Files 1790 1031 -759
Lines 38329 25612 -12717
Branches 4219 2507 -1712
============================================
- Hits 20487 13517 -6970
+ Misses 16857 10943 -5914
- Partials 985 1152 +167
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1257 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `23.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 30.20% -23.25%
+ Complexity 4110 2315 -1795
=============================================
Files 1790 1011 -779
Lines 38329 24980 -13349
Branches 4219 2433 -1786
=============================================
- Hits 20487 7546 -12941
+ Misses 16857 16853 -4
+ Partials 985 581 -404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1412 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `13.38%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 49.71% +13.38%
- Complexity 2178 3674 +1496
=============================================
Files 812 1032 +220
Lines 20047 25373 +5326
Branches 1908 2487 +579
=============================================
+ Hits 7283 12615 +5332
+ Misses 12222 11702 -520
- Partials 542 1056 +514
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [393 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803298389
Also, this pull request includes the Jedis test cases. Please recheck your codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `5.68%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 47.76% -5.69%
+ Complexity 4110 3554 -556
============================================
Files 1790 1012 -778
Lines 38329 25036 -13293
Branches 4219 2450 -1769
============================================
- Hits 20487 11958 -8529
+ Misses 16857 12047 -4810
- Partials 985 1031 +46
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1297 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **increase** coverage by `1.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 53.45% 54.60% +1.15%
+ Complexity 4110 4038 -72
============================================
Files 1790 1031 -759
Lines 38329 25629 -12700
Branches 4219 2508 -1711
============================================
- Hits 20487 13994 -6493
+ Misses 16857 10462 -6395
- Partials 985 1173 +188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1248 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.15%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 53.48% +17.15%
- Complexity 2178 4000 +1822
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13676 +6393
+ Misses 12222 10724 -1498
- Partials 542 1171 +629
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `77.77% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...arch/ZipkinStorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `37.50% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...g/oap/server/storage/plugin/zipkin/ZipkinSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW4uamF2YQ==) | `75.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [467 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 39.85% +3.52%
- Complexity 2178 2855 +677
============================================
Files 812 1012 +200
Lines 20047 25083 +5036
Branches 1908 2440 +532
============================================
+ Hits 7283 9996 +2713
- Misses 12222 14296 +2074
- Partials 542 791 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...pm/agent/core/context/SW8ExtensionCarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhFeHRlbnNpb25DYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...sticsearch7/StorageModuleElasticsearch7Config.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdDb25maWcuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `13.62%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 49.95% +13.62%
- Complexity 2178 3692 +1514
=============================================
Files 812 1032 +220
Lines 20047 25373 +5326
Branches 1908 2487 +579
=============================================
+ Hits 7283 12674 +5391
+ Misses 12222 11641 -581
- Partials 542 1058 +516
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [396 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 39.74% +3.42%
- Complexity 2178 2901 +723
============================================
Files 812 979 +167
Lines 20047 23892 +3845
Branches 1908 2309 +401
============================================
+ Hits 7283 9497 +2214
- Misses 12222 13593 +1371
- Partials 542 802 +260
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...erver/storage/plugin/jdbc/h2/dao/H2StorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyU3RvcmFnZURBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/storage/plugin/jdbc/h2/dao/H2RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUmVjb3JkREFPLmphdmE=) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ing/oap/server/storage/plugin/jdbc/SQLBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-92.31%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [331 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 185 -627
Lines 20047 4508 -15539
Branches 1908 505 -1403
============================================
- Hits 7283 0 -7283
+ Misses 12222 4508 -7714
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [963 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `6.13%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 42.46% +6.13%
- Complexity 2178 3132 +954
============================================
Files 812 982 +170
Lines 20047 24198 +4151
Branches 1908 2366 +458
============================================
+ Hits 7283 10276 +2993
- Misses 12222 13062 +840
- Partials 542 860 +318
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `73.33% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `72.97% <0.00%> (ø)` | `9.00% <0.00%> (?%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `49.45% <0.00%> (ø)` | `23.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `67.79% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
| [.../agent/core/plugin/bytebuddy/AbstractJunction.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9BYnN0cmFjdEp1bmN0aW9uLmphdmE=) | `66.66% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 190 -622
Lines 20047 4544 -15503
Branches 1908 515 -1393
============================================
- Hits 7283 0 -7283
+ Misses 12222 4544 -7678
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [968 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803718551
> @xuanyu66
> I've read your issue and code, but I still don't quite understand the reason for the bug, can you describe your usage scenario? Because it works fine with the following configuration
>
> ```
> <Configuration>
> <Appenders>
> <Console name="_Console" target="SYSTEM_OUT">
> <PatternLayout pattern="%d [%traceId] %-5p %c{1}:%L - %m%n"/>
> </Console>
> <Async name="Console">
> <AppenderRef ref="_Console"/>
> </Async>
> </Appenders>
> <Loggers>
> <Root level="INFO">
> <Appender-Ref ref="Console"/>
> </Root>
> </Loggers>
> </Configuration>
> ```
```
Configuration:
properties:
property:
- name: logPath
value: XXXX
- name: filename
value: XXXX
- name: pattern
value: "XXXXX"
- name: httpRequestPattern
value: "XXXXXX"
status: "info"
Appenders:
RollingRandomAccessFile:
- name: "FileAppender"
fileName: "${logPath}${filename}"
filePattern: "${logPath}${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${pattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
- name: "AnalysisFileAppender"
fileName: "${logPath}analysis-${filename}"
filePattern: "${logPath}analysis-${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${pattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
- name: "HTTPRequestFileAppender"
fileName: "${logPath}http-request-${filename}"
filePattern: "${logPath}http-request-${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${httpRequestPattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
- name: "RPCRequestFileAppender"
fileName: "${logPath}rpc-request-${filename}"
filePattern: "${logPath}rpc-request-${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${pattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
Async:
- name: "AsyncFileAppender"
AppenderRef:
- ref: FileAppender
bufferSize: 10000
- name: "AsyncAnalysisFileAppender"
AppenderRef:
- ref: AnalysisFileAppender
bufferSize: 15000
- name: "AsyncHTTPRequestFileAppender"
AppenderRef:
- ref: HTTPRequestFileAppender
bufferSize: 10000
- name: "AsyncRPCRequestFileAppender"
AppenderRef:
- ref: RPCRequestFileAppender
bufferSize: 10000
Loggers:
AsyncLogger:
- name: "RequestLogger"
level: info
additivity: false
AppenderRef:
- ref: AsyncHTTPRequestFileAppender
- name: "RpcRequestLogger"
level: info
additivity: false
AppenderRef:
- ref: AsyncRPCRequestFileAppender
- name: "AnalysisLogger"
level: info
additivity: false
AppenderRef:
- ref: AsyncAnalysisFileAppender
AsyncRoot:
level: info
AppenderRef:
- ref: AsyncFileAppender
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `11.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 47.51% +11.19%
- Complexity 2178 3468 +1290
=============================================
Files 812 998 +186
Lines 20047 24596 +4549
Branches 1908 2407 +499
=============================================
+ Hits 7283 11688 +4405
+ Misses 12222 11923 -299
- Partials 542 985 +443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...gent/core/plugin/match/logical/LogicalOrMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL2xvZ2ljYWwvTG9naWNhbE9yTWF0Y2guamF2YQ==) | `84.61% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.91%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.24% +17.91%
- Complexity 2178 4035 +1857
=============================================
Files 812 1032 +220
Lines 20047 25586 +5539
Branches 1908 2507 +599
=============================================
+ Hits 7283 13879 +6596
+ Misses 12222 10518 -1704
- Partials 542 1189 +647
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...p/server/receiver/zipkin/ZipkinReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJNb2R1bGUuamF2YQ==) | `66.66% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `21.42% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `83.78% <0.00%> (ø)` | `9.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `75.92% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| ... and [473 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r595976527
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
> > But deserialization and then serialization will make Log4jLogEvent lose SkyWalkingDynamicField, which cause no trace id in log
OK, I just read your issue. If this is the case, why don't you enhance `createMemento` to copy this new field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.12% +17.79%
- Complexity 2178 4032 +1854
=============================================
Files 812 1031 +219
Lines 20047 25582 +5535
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10554 -1668
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/plugin/PluginBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkJvb3RzdHJhcC5qYXZh) | `74.07% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [...gent/core/context/trace/StackBasedTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TdGFja0Jhc2VkVHJhY2luZ1NwYW4uamF2YQ==) | `75.00% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [.../server/receiver/zipkin/handler/SpanProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...arch/ZipkinStorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `37.50% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| ... and [472 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `20.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 57.00% +20.67%
+ Complexity 2178 845 -1333
=============================================
Files 812 182 -630
Lines 20047 4433 -15614
Branches 1908 495 -1413
=============================================
- Hits 7283 2527 -4756
+ Misses 12222 1590 -10632
+ Partials 542 316 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-15.39%)` | `6.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...ary/module/ServiceNotProvidedRuntimeException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL1NlcnZpY2VOb3RQcm92aWRlZFJ1bnRpbWVFeGNlcHRpb24uamF2YQ==) | | | |
| [...ing/oap/server/storage/plugin/jdbc/SQLBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMQnVpbGRlci5qYXZh) | | | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | | | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | | | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | | | |
| [...server/storage/plugin/jdbc/h2/H2StorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlQ29uZmlnLmphdmE=) | | | |
| [.../configuration/grpc/GRPCConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlndXJhdGlvblByb3ZpZGVyLmphdmE=) | | | |
| [...library/module/ModuleNotFoundRuntimeException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZU5vdEZvdW5kUnVudGltZUV4Y2VwdGlvbi5qYXZh) | | | |
| ... and [959 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] J-Cod3r commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
J-Cod3r commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803775376
> @J-Cod3r So, this PR is good for you, right?
right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `15.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 51.62% +15.29%
- Complexity 2178 3769 +1591
=============================================
Files 812 998 +186
Lines 20047 24667 +4620
Branches 1908 2415 +507
=============================================
+ Hits 7283 12734 +5451
+ Misses 12222 10845 -1377
- Partials 542 1088 +546
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...apm/agent/core/profile/ProfileStatusReference.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzUmVmZXJlbmNlLmphdmE=) | `40.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `33.33% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `76.92% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...ore/plugin/bootstrap/BootstrapInstrumentBoost.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBJbnN0cnVtZW50Qm9vc3QuamF2YQ==) | `15.49% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...g/apm/agent/core/logging/core/SystemOutWriter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1N5c3RlbU91dFdyaXRlci5qYXZh) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `46.29% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| ... and [407 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `7.68%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 28.64% -7.69%
+ Complexity 2178 2083 -95
============================================
Files 812 1001 +189
Lines 20047 24304 +4257
Branches 1908 2381 +473
============================================
- Hits 7283 6961 -322
- Misses 12222 16817 +4595
+ Partials 542 526 -16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/analyzer/provider/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=) | `4.16% <0.00%> (-93.75%)` | `2.00% <0.00%> (-15.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803770104
@J-Cod3r So, this PR is good for you, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `9.61%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 45.94% +9.61%
- Complexity 2178 3332 +1154
============================================
Files 812 1001 +189
Lines 20047 24460 +4413
Branches 1908 2398 +490
============================================
+ Hits 7283 11238 +3955
- Misses 12222 12277 +55
- Partials 542 945 +403
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 206 -606
Lines 20047 4819 -15228
Branches 1908 548 -1360
============================================
- Hits 7283 0 -7283
+ Misses 12222 4819 -7403
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [984 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `11.72%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 48.05% +11.72%
- Complexity 2178 3468 +1290
=============================================
Files 812 982 +170
Lines 20047 24321 +4274
Branches 1908 2374 +466
=============================================
+ Hits 7283 11688 +4405
+ Misses 12222 11648 -574
- Partials 542 985 +443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `81.25% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `82.35% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
| [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | `50.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [.../status/AnnotationMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvQW5ub3RhdGlvbk1hdGNoRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `66.66% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `14.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 39.06% -14.40%
+ Complexity 4110 2886 -1224
=============================================
Files 1790 1012 -778
Lines 38329 25192 -13137
Branches 4219 2453 -1766
=============================================
- Hits 20487 9840 -10647
+ Misses 16857 14583 -2274
+ Partials 985 769 -216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.12% +17.79%
- Complexity 2178 4032 +1854
=============================================
Files 812 1031 +219
Lines 20047 25582 +5535
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10554 -1668
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...rage/plugin/zipkin/ZipkinSpanRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.55% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ywalking/apm/agent/core/context/tag/StringTag.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvU3RyaW5nVGFnLmphdmE=) | `75.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/jvm/cpu/CPUMetricsAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVNZXRyaWNzQWNjZXNzb3IuamF2YQ==) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/trace/SpanLayer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TcGFuTGF5ZXIuamF2YQ==) | `50.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [.../agent/core/context/ids/NewDistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvTmV3RGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...pm/agent/core/jvm/memorypool/MemoryPoolModule.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbE1vZHVsZS5qYXZh) | `96.87% <0.00%> (ø)` | `11.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| ... and [472 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `12.73%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 49.06% +12.73%
- Complexity 2178 3632 +1454
=============================================
Files 812 1032 +220
Lines 20047 25373 +5326
Branches 1908 2487 +579
=============================================
+ Hits 7283 12449 +5166
+ Misses 12222 11877 -345
- Partials 542 1047 +505
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [381 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.15%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 53.48% +17.15%
- Complexity 2178 4000 +1822
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13676 +6393
+ Misses 12222 10724 -1498
- Partials 542 1171 +629
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `51.78% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...agent/core/boot/AgentPackageNotFoundException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9BZ2VudFBhY2thZ2VOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [467 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `12.75%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 49.08% +12.75%
- Complexity 2178 3633 +1455
=============================================
Files 812 1032 +220
Lines 20047 25373 +5326
Branches 1908 2487 +579
=============================================
+ Hits 7283 12455 +5172
+ Misses 12222 11871 -351
- Partials 542 1047 +505
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [381 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `15.86%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 52.19% +15.86%
- Complexity 2178 3929 +1751
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13347 +6064
+ Misses 12222 11087 -1135
- Partials 542 1137 +595
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...agent/core/boot/AgentPackageNotFoundException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9BZ2VudFBhY2thZ2VOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...orage/plugin/elasticsearch7/dao/MetricsEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vTWV0cmljc0VzN0RBTy5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...t/core/jvm/memorypool/ParallelCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvUGFyYWxsZWxDb2xsZWN0b3JNb2R1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...m/agent/core/plugin/match/MultiClassNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL011bHRpQ2xhc3NOYW1lTWF0Y2guamF2YQ==) | `85.71% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| ... and [455 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `8.94%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 45.27% +8.94%
- Complexity 2178 3404 +1226
============================================
Files 812 1032 +220
Lines 20047 25363 +5316
Branches 1908 2486 +578
============================================
+ Hits 7283 11484 +4201
- Misses 12222 12916 +694
- Partials 542 963 +421
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803718551
> @xuanyu66
> I've read your issue and code, but I still don't quite understand the reason for the bug, can you describe your usage scenario? Because it works fine with the following configuration
>
> ```
> <Configuration>
> <Appenders>
> <Console name="_Console" target="SYSTEM_OUT">
> <PatternLayout pattern="%d [%traceId] %-5p %c{1}:%L - %m%n"/>
> </Console>
> <Async name="Console">
> <AppenderRef ref="_Console"/>
> </Async>
> </Appenders>
> <Loggers>
> <Root level="INFO">
> <Appender-Ref ref="Console"/>
> </Root>
> </Loggers>
> </Configuration>
> ```
```
Configuration:
properties:
property:
- name: logPath
value: XXXX
- name: filename
value: XXXX
- name: pattern
value: "%d{yyyy-MM-dd HH:mm:ss.SSS} [%p] [%t] [%c] @@@traceId=%traceId@@@ %m%n"
- name: httpRequestPattern
value: "%-d{yyyy-MM-dd HH:mm:ss.SSS} @@@traceId=%traceId@@@ %m%n"
status: "info"
Appenders:
RollingRandomAccessFile:
- name: "FileAppender"
fileName: "${logPath}${filename}"
filePattern: "${logPath}${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${pattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
- name: "AnalysisFileAppender"
fileName: "${logPath}analysis-${filename}"
filePattern: "${logPath}analysis-${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${pattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
- name: "HTTPRequestFileAppender"
fileName: "${logPath}http-request-${filename}"
filePattern: "${logPath}http-request-${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${httpRequestPattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
- name: "RPCRequestFileAppender"
fileName: "${logPath}rpc-request-${filename}"
filePattern: "${logPath}rpc-request-${filename}.%d{yyyy-MM-dd}"
PatternLayout:
pattern: "${pattern}"
Policies:
TimeBasedTriggeringPolicy: {}
immediateFlush: false
Async:
- name: "AsyncFileAppender"
AppenderRef:
- ref: FileAppender
bufferSize: 10000
- name: "AsyncAnalysisFileAppender"
AppenderRef:
- ref: AnalysisFileAppender
bufferSize: 15000
- name: "AsyncHTTPRequestFileAppender"
AppenderRef:
- ref: HTTPRequestFileAppender
bufferSize: 10000
- name: "AsyncRPCRequestFileAppender"
AppenderRef:
- ref: RPCRequestFileAppender
bufferSize: 10000
Loggers:
AsyncLogger:
- name: "RequestLogger"
level: info
additivity: false
AppenderRef:
- ref: AsyncHTTPRequestFileAppender
- name: "RpcRequestLogger"
level: info
additivity: false
AppenderRef:
- ref: AsyncRPCRequestFileAppender
- name: "AnalysisLogger"
level: info
additivity: false
AppenderRef:
- ref: AsyncAnalysisFileAppender
AsyncRoot:
level: info
AppenderRef:
- ref: AsyncFileAppender
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **increase** coverage by `1.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 53.45% 54.75% +1.30%
+ Complexity 4110 4044 -66
============================================
Files 1790 1031 -759
Lines 38329 25629 -12700
Branches 4219 2508 -1711
============================================
- Hits 20487 14034 -6453
+ Misses 16857 10413 -6444
- Partials 985 1182 +197
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1248 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `14.39%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 50.72% +14.39%
- Complexity 2178 3838 +1660
=============================================
Files 812 1029 +217
Lines 20047 25570 +5523
Branches 1908 2503 +595
=============================================
+ Hits 7283 12970 +5687
+ Misses 12222 11497 -725
- Partials 542 1103 +561
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...walking/apm/agent/core/logging/api/LogManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9hcGkvTG9nTWFuYWdlci5qYXZh) | `50.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...orage/plugin/elasticsearch7/dao/MetricsEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vTWV0cmljc0VzN0RBTy5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ugin/elasticsearch7/query/MetadataQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9NZXRhZGF0YVF1ZXJ5RXM3REFPLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `67.79% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/jvm/cpu/CPUMetricsAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVNZXRyaWNzQWNjZXNzb3IuamF2YQ==) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...g/oap/server/storage/plugin/zipkin/ZipkinSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW4uamF2YQ==) | `75.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [439 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `4.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 32.27% -4.06%
- Complexity 2178 2293 +115
============================================
Files 812 980 +168
Lines 20047 23969 +3922
Branches 1908 2320 +412
============================================
+ Hits 7283 7736 +453
- Misses 12222 15672 +3450
- Partials 542 561 +19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-8.00%)` | |
| [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (-1.00%)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.73%)` | `2.00% <0.00%> (-19.00%)` | |
| [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-84.00%)` | `0.00% <0.00%> (-22.00%)` | |
| [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [303 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `16.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 36.32% 19.41% -16.92%
+ Complexity 2178 1440 -738
=============================================
Files 812 978 +166
Lines 20047 23601 +3554
Branches 1908 2252 +344
=============================================
- Hits 7283 4583 -2700
- Misses 12222 18703 +6481
+ Partials 542 315 -227
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ng/oap/meter/analyzer/dsl/SampleFamilyBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] J-Cod3r commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
J-Cod3r commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803702658
@xuanyu66
I've read your issue and code, but I still don't quite understand the reason for the bug, can you describe your usage scenario? Because it works fine with the following configuration
```xml
<Configuration>
<Appenders>
<Console name="_Console" target="SYSTEM_OUT">
<PatternLayout pattern="%d [%traceId] %-5p %c{1}:%L - %m%n"/>
</Console>
<Async name="Console">
<AppenderRef ref="_Console"/>
</Async>
</Appenders>
<Loggers>
<Root level="INFO">
<Appender-Ref ref="Console"/>
</Root>
</Loggers>
</Configuration>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `6.99%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 46.45% -7.00%
+ Complexity 4110 3486 -624
============================================
Files 1790 1012 -778
Lines 38329 25022 -13307
Branches 4219 2449 -1770
============================================
- Hits 20487 11625 -8862
+ Misses 16857 12399 -4458
- Partials 985 998 +13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1301 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `4.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 32.12% -4.21%
- Complexity 2178 2365 +187
============================================
Files 812 1011 +199
Lines 20047 24872 +4825
Branches 1908 2408 +500
============================================
+ Hits 7283 7990 +707
- Misses 12222 16302 +4080
- Partials 542 580 +38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-8.00%)` | |
| [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (-1.00%)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.73%)` | `2.00% <0.00%> (-19.00%)` | |
| [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-84.00%)` | `0.00% <0.00%> (-22.00%)` | |
| [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [335 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `4.33%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 40.66% +4.33%
- Complexity 2178 3033 +855
============================================
Files 812 1001 +189
Lines 20047 24371 +4324
Branches 1908 2390 +482
============================================
+ Hits 7283 9911 +2628
- Misses 12222 13616 +1394
- Partials 542 844 +302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [248 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.82%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.15% +17.82%
- Complexity 2178 4032 +1854
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10543 -1679
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `77.77% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...arch/ZipkinStorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `37.50% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...g/oap/server/storage/plugin/zipkin/ZipkinSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW4uamF2YQ==) | `75.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [470 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.73%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 40.06% +3.73%
- Complexity 2178 2995 +817
============================================
Files 812 1001 +189
Lines 20047 24370 +4323
Branches 1908 2386 +478
============================================
+ Hits 7283 9763 +2480
- Misses 12222 13771 +1549
- Partials 542 836 +294
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...ver/analyzer/provider/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=) | `96.87% <0.00%> (-1.05%)` | `16.00% <0.00%> (-1.00%)` | |
| ... and [238 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `9.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 45.99% +9.66%
- Complexity 2178 3365 +1187
============================================
Files 812 1011 +199
Lines 20047 24861 +4814
Branches 1908 2402 +494
============================================
+ Hits 7283 11434 +4151
- Misses 12222 12439 +217
- Partials 542 988 +446
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-8.00%)` | |
| [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (-1.00%)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.73%)` | `2.00% <0.00%> (-19.00%)` | |
| [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-84.00%)` | `0.00% <0.00%> (-22.00%)` | |
| [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [370 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.15%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 53.48% +17.15%
- Complexity 2178 4000 +1822
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13676 +6393
+ Misses 12222 10724 -1498
- Partials 542 1171 +629
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ing/apm/agent/core/context/trace/TraceSegment.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnQuamF2YQ==) | `77.50% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
| [...pm/agent/core/logging/core/PatternLogResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dSZXNvbHZlci5qYXZh) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/plugin/PluginException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../status/AnnotationMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvQW5ub3RhdGlvbk1hdGNoRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `66.66% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (ø)` | `11.00% <0.00%> (?%)` | |
| ... and [467 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 184 -628
Lines 20047 4495 -15552
Branches 1908 505 -1403
============================================
- Hits 7283 0 -7283
+ Misses 12222 4495 -7727
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [962 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `8.82%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 27.50% -8.83%
+ Complexity 2178 1995 -183
============================================
Files 812 980 +168
Lines 20047 23864 +3817
Branches 1908 2311 +403
============================================
- Hits 7283 6564 -719
- Misses 12222 16842 +4620
+ Partials 542 458 -84
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-8.00%)` | |
| [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ider/handler/v8/grpc/ManagementServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L2dycGMvTWFuYWdlbWVudFNlcnZpY2VIYW5kbGVyLmphdmE=) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-4.00%)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.73%)` | `2.00% <0.00%> (-19.00%)` | |
| [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-84.00%)` | `0.00% <0.00%> (-22.00%)` | |
| ... and [255 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803601023
@J-Cod3r Can you please review again, Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `12.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 48.89% +12.56%
- Complexity 2178 3623 +1445
=============================================
Files 812 1012 +200
Lines 20047 25092 +5045
Branches 1908 2440 +532
=============================================
+ Hits 7283 12268 +4985
+ Misses 12222 11753 -469
- Partials 542 1071 +529
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `56.52% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
| ... and [361 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.12% +17.79%
- Complexity 2178 4032 +1854
=============================================
Files 812 1031 +219
Lines 20047 25582 +5535
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10554 -1668
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `51.78% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...agent/core/boot/AgentPackageNotFoundException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9BZ2VudFBhY2thZ2VOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [472 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `15.60%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 51.93% +15.60%
- Complexity 2178 3825 +1647
=============================================
Files 812 1032 +220
Lines 20047 25477 +5430
Branches 1908 2495 +587
=============================================
+ Hits 7283 13231 +5948
+ Misses 12222 11152 -1070
- Partials 542 1094 +552
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [436 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 53.36% -0.09%
+ Complexity 4110 3980 -130
============================================
Files 1790 1031 -759
Lines 38329 25629 -12700
Branches 4219 2508 -1711
============================================
- Hits 20487 13678 -6809
+ Misses 16857 10789 -6068
- Partials 985 1162 +177
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1256 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 178 -634
Lines 20047 4441 -15606
Branches 1908 507 -1401
============================================
- Hits 7283 0 -7283
+ Misses 12222 4441 -7781
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [956 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `1.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 37.69% +1.36%
- Complexity 2178 2741 +563
============================================
Files 812 1011 +199
Lines 20047 25025 +4978
Branches 1908 2439 +531
============================================
+ Hits 7283 9434 +2151
- Misses 12222 14863 +2641
- Partials 542 728 +186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [329 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `29.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 24.09% -29.36%
+ Complexity 4110 1871 -2239
=============================================
Files 1790 1011 -779
Lines 38329 24679 -13650
Branches 4219 2360 -1859
=============================================
- Hits 20487 5947 -14540
- Misses 16857 18285 +1428
+ Partials 985 447 -538
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1444 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `18.67%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 55.00% +18.67%
- Complexity 2178 4064 +1886
=============================================
Files 812 1032 +220
Lines 20047 25596 +5549
Branches 1908 2508 +600
=============================================
+ Hits 7283 14078 +6795
+ Misses 12222 10303 -1919
- Partials 542 1215 +673
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `75.92% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/toolkit/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/trace/SpanLayer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TcGFuTGF5ZXIuamF2YQ==) | `50.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `85.71% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/ConstructorInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ29uc3RydWN0b3JJbnRlci5qYXZh) | `69.23% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| ... and [476 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `21.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 57.81% +21.48%
+ Complexity 2178 845 -1333
=============================================
Files 812 178 -634
Lines 20047 4371 -15676
Branches 1908 490 -1418
=============================================
- Hits 7283 2527 -4756
+ Misses 12222 1528 -10694
+ Partials 542 316 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-15.39%)` | `6.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...figuration/apollo/ApolloConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwb2xsby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBvbGxvL0Fwb2xsb0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | | | |
| [...ary/module/ServiceNotProvidedRuntimeException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL1NlcnZpY2VOb3RQcm92aWRlZFJ1bnRpbWVFeGNlcHRpb24uamF2YQ==) | | | |
| [...r/parser/performance/BrowserPerfDataDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9Ccm93c2VyUGVyZkRhdGFEZWNvcmF0b3IuamF2YQ==) | | | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | | | |
| [...core/analysis/metrics/expression/BooleanMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0Jvb2xlYW5NYXRjaC5qYXZh) | | | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | | | |
| [...pache/skywalking/oal/rt/parser/FilterMatchers.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9GaWx0ZXJNYXRjaGVycy5qYXZh) | | | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | | | |
| ... and [955 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r598282760
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/CreateMementoInterceptor.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.log4j.v2.x.async;
+
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor;
+
+import java.lang.reflect.Method;
+
+public class CreateMementoInterceptor implements StaticMethodsAroundInterceptor {
+
+ private static final String TRACE_ID = "TRACE_ID";
+
+ @Override
+ public void beforeMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes,
+ MethodInterceptResult result) {
+ if (allArguments[0] instanceof EnhancedInstance) {
+ EnhancedInstance instances = (EnhancedInstance) allArguments[0];
+ ContextManager.getRuntimeContext().put(TRACE_ID, instances.getSkyWalkingDynamicField());
+ }
+ }
+
+ @Override
+ public Object afterMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes,
+ Object ret) {
+ if (ret instanceof EnhancedInstance) {
+ EnhancedInstance instances = (EnhancedInstance) ret;
+ instances.setSkyWalkingDynamicField(ContextManager.getRuntimeContext().get(TRACE_ID));
+ ContextManager.getRuntimeContext().remove(TRACE_ID);
+ }
+ return ret;
Review comment:
Yes, you are right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.82%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.15% +17.82%
- Complexity 2178 4032 +1854
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10543 -1679
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...rage/plugin/zipkin/ZipkinSpanRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.55% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ywalking/apm/agent/core/context/tag/StringTag.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvU3RyaW5nVGFnLmphdmE=) | `75.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/jvm/cpu/CPUMetricsAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVNZXRyaWNzQWNjZXNzb3IuamF2YQ==) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/trace/SpanLayer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TcGFuTGF5ZXIuamF2YQ==) | `50.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [.../agent/core/context/ids/NewDistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvTmV3RGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | `53.57% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [470 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 186 -626
Lines 20047 4580 -15467
Branches 1908 522 -1386
============================================
- Hits 7283 0 -7283
+ Misses 12222 4580 -7642
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [964 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r598113399
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
@J-Cod3r thanks , I will resubmit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 175 -637
Lines 20047 4327 -15720
Branches 1908 486 -1422
============================================
- Hits 7283 0 -7283
+ Misses 12222 4327 -7895
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [953 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `12.74%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 40.70% -12.75%
+ Complexity 4110 2997 -1113
=============================================
Files 1790 979 -811
Lines 38329 24008 -14321
Branches 4219 2347 -1872
=============================================
- Hits 20487 9772 -10715
+ Misses 16857 13396 -3461
+ Partials 985 840 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `10.82%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 42.62% -10.83%
+ Complexity 4110 3104 -1006
=============================================
Files 1790 979 -811
Lines 38329 24021 -14308
Branches 4219 2348 -1871
=============================================
- Hits 20487 10240 -10247
+ Misses 16857 12909 -3948
+ Partials 985 872 -113
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597391099
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/CreateMementoInterceptor.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.log4j.v2.x.async;
+
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor;
+
+import java.lang.reflect.Method;
+
+public class CreateMementoInterceptor implements StaticMethodsAroundInterceptor {
+
+ private String tag;
Review comment:
Use instance's field is very dangerous, we don't recommend doing so. All `Interceptor` instances are shared. Read how `InstMethodsInter` works, you should have a better understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597392016
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
I didn't read the log4j2 source codes as you did. I am confused. You said, there is an issue caused by the object clone, which means you need to propagate the context through copy/paste the dynamic field. But clearly, this code doesn't match your description. This is about setting the current trace id to a new object's dynamic field.
I think we miss some context here. If you feel the words are hard to understand, you could draw somethings(diagram) to show the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `53.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 0.00% -53.46%
============================================
Files 1790 171 -1619
Lines 38329 4268 -34061
Branches 4219 485 -3734
============================================
- Hits 20487 0 -20487
+ Misses 16857 4268 -12589
+ Partials 985 0 -985
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1767 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 170 -642
Lines 20047 4228 -15819
Branches 1908 481 -1427
============================================
- Hits 7283 0 -7283
+ Misses 12222 4228 -7994
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [948 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `4.33%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 40.66% +4.33%
- Complexity 2178 3033 +855
============================================
Files 812 1001 +189
Lines 20047 24371 +4324
Branches 1908 2390 +482
============================================
+ Hits 7283 9911 +2628
- Misses 12222 13616 +1394
- Partials 542 844 +302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [248 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `12.59%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 40.85% -12.60%
+ Complexity 4110 2991 -1119
=============================================
Files 1790 973 -817
Lines 38329 23893 -14436
Branches 4219 2328 -1891
=============================================
- Hits 20487 9762 -10725
+ Misses 16857 13291 -3566
+ Partials 985 840 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `15.26%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 51.58% +15.26%
- Complexity 2178 3890 +1712
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13192 +5909
+ Misses 12222 11255 -967
- Partials 542 1124 +582
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/plugin/PluginBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkJvb3RzdHJhcC5qYXZh) | `74.07% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `50.00% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [...gent/core/context/trace/StackBasedTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TdGFja0Jhc2VkVHJhY2luZ1NwYW4uamF2YQ==) | `75.00% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [.../server/receiver/zipkin/handler/SpanProcessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [452 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `20.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 57.12% +20.79%
+ Complexity 2178 845 -1333
=============================================
Files 812 181 -631
Lines 20047 4424 -15623
Branches 1908 494 -1414
=============================================
- Hits 7283 2527 -4756
+ Misses 12222 1581 -10641
+ Partials 542 316 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-15.39%)` | `6.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...kywalking/oap/server/core/UnexpectedException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvVW5leHBlY3RlZEV4Y2VwdGlvbi5qYXZh) | | | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | | | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | | | |
| [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | | | |
| [...server/library/module/ModuleNotFoundException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZU5vdEZvdW5kRXhjZXB0aW9uLmphdmE=) | | | |
| [...ver/core/browser/source/BrowserAppPageTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBhZ2VUcmFmZmljLmphdmE=) | | | |
| [...aop/server/receiver/mesh/MeshReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hSZWNlaXZlclByb3ZpZGVyLmphdmE=) | | | |
| [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | | | |
| ... and [958 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `3.98%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 32.34% -3.99%
- Complexity 2178 2323 +145
============================================
Files 812 982 +170
Lines 20047 24189 +4142
Branches 1908 2366 +458
============================================
+ Hits 7283 7823 +540
- Misses 12222 15797 +3575
- Partials 542 569 +27
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/plugin/PluginBootstrap.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkJvb3RzdHJhcC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...gent/core/context/trace/StackBasedTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9TdGFja0Jhc2VkVHJhY2luZ1NwYW4uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 176 -636
Lines 20047 4391 -15656
Branches 1908 503 -1405
============================================
- Hits 7283 0 -7283
+ Misses 12222 4391 -7831
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [954 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597383550
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
What I've done here is to avoid AsyncAppenderMethodIntercepto to cover trace id with null , because as you said, ContextManager.getGlobalTraceId() doesn's works , it's another thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `19.22%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ed1b57a differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 55.55% +19.22%
- Complexity 2178 4091 +1913
=============================================
Files 812 1033 +221
Lines 20047 25635 +5588
Branches 1908 2508 +600
=============================================
+ Hits 7283 14242 +6959
+ Misses 12222 10187 -2035
- Partials 542 1206 +664
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `35.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [.../agent/core/commands/CommandSerialNumberCache.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcmlhbE51bWJlckNhY2hlLmphdmE=) | `81.81% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...sticsearch7/StorageModuleElasticsearch7Config.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9TdG9yYWdlTW9kdWxlRWxhc3RpY3NlYXJjaDdDb25maWcuamF2YQ==) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...rage/plugin/zipkin/ZipkinSpanRecordDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmREaXNwYXRjaGVyLmphdmE=) | `5.55% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [474 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r598283085
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
@xuanyu66 When you are ready, ask @J-Cod3r to review. He is more qualified than me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597772500
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
@J-Cod3r Are you still around? Could you share what happens here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `27.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 26.23% -27.22%
+ Complexity 4110 2007 -2103
=============================================
Files 1790 1011 -779
Lines 38329 24688 -13641
Branches 4219 2360 -1859
=============================================
- Hits 20487 6477 -14010
- Misses 16857 17731 +874
+ Partials 985 480 -505
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1437 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r596851260
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
@xuanyu66 We don't discuss under the case, what you did in the private.
In the community, we all focus on the public and upstream version only. So, forgive me can't give any feedback about your description.
We replied based on your case. You should explain why our ideas are not good or correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 39.87% +3.54%
- Complexity 2178 2849 +671
============================================
Files 812 1011 +199
Lines 20047 25044 +4997
Branches 1908 2439 +531
============================================
+ Hits 7283 9986 +2703
- Misses 12222 14267 +2045
- Partials 542 791 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/tag/AbstractTag.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvQWJzdHJhY3RUYWcuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [345 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r597770395
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
You can see CreateMementoInstrumentation, which propagates the context through copy/paste the dynamic field.
AsyncAppenderInstrumentation isn't written by me, I just modify it.
> This is about setting the current trace id to a new object's dynamic
the AsyncAppenderInstrumentation and AsyncLoggerConfigInstrumentation is not added by me. I don't why do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] J-Cod3r commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
J-Cod3r commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r598102889
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
> What I've done here is to avoid AsyncAppenderMethodIntercepto to cover trace id with null , because as you said, ContextManager.getGlobalTraceId() doesn's works , it's another thread
@xuanyu66
This should not be the reason, AsyncAppender will put Log4jLogEvent into the queue, then another thread will take it out and print the log, AsyncAppenderMethodInterceptor intercept before putting it into the queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `15.13%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 51.46% +15.13%
- Complexity 2178 3763 +1585
=============================================
Files 812 998 +186
Lines 20047 24667 +4620
Branches 1908 2415 +507
=============================================
+ Hits 7283 12695 +5412
+ Misses 12222 10891 -1331
- Partials 542 1081 +539
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../agent/core/context/ids/NewDistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvTmV3RGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/RuntimeContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dC5qYXZh) | `41.66% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...skywalking/apm/agent/core/logging/core/Parser.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhcnNlci5qYXZh) | `60.43% <0.00%> (ø)` | `16.00% <0.00%> (?%)` | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | `50.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| ... and [406 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.78%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.11% +17.78%
- Complexity 2178 4032 +1854
=============================================
Files 812 1032 +220
Lines 20047 25586 +5539
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10558 -1664
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...walking/apm/agent/core/logging/api/LogManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9hcGkvTG9nTWFuYWdlci5qYXZh) | `50.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...orage/plugin/elasticsearch7/dao/MetricsEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vTWV0cmljc0VzN0RBTy5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ugin/elasticsearch7/query/MetadataQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9NZXRhZGF0YVF1ZXJ5RXM3REFPLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `67.79% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/jvm/cpu/CPUMetricsAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVNZXRyaWNzQWNjZXNzb3IuamF2YQ==) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...g/oap/server/storage/plugin/zipkin/ZipkinSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tZWxhc3RpY3NlYXJjaDctcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW4uamF2YQ==) | `75.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `81.25% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [473 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `53.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 0.00% -53.46%
============================================
Files 1790 171 -1619
Lines 38329 4268 -34061
Branches 4219 485 -3734
============================================
- Hits 20487 0 -20487
+ Misses 16857 4268 -12589
+ Partials 985 0 -985
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1767 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 187 -625
Lines 20047 4619 -15428
Branches 1908 523 -1385
============================================
- Hits 7283 0 -7283
+ Misses 12222 4619 -7603
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [965 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `16.56%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 52.89% +16.56%
- Complexity 2178 3959 +1781
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13525 +6242
+ Misses 12222 10892 -1330
- Partials 542 1154 +612
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Mb2dRdWVyeUVzN0RBTy5qYXZh) | `3.22% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <0.00%> (ø)` | `25.00% <0.00%> (?%)` | |
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/trace/LocalSpan.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2NhbFNwYW4uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [456 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `10.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 46.60% +10.27%
- Complexity 2178 3409 +1231
=============================================
Files 812 1011 +199
Lines 20047 24861 +4814
Branches 1908 2402 +494
=============================================
+ Hits 7283 11586 +4303
- Misses 12222 12283 +61
- Partials 542 992 +450
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...king/oap/server/core/analysis/metrics/IntList.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9JbnRMaXN0LmphdmE=) | `0.00% <0.00%> (-88.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-8.00%)` | |
| [...oap/server/fetcher/prometheus/http/HttpClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9odHRwL0h0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (-1.00%)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `5.55% <0.00%> (-84.73%)` | `2.00% <0.00%> (-19.00%)` | |
| [...server/library/util/prometheus/parser/Context.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvQ29udGV4dC5qYXZh) | `0.00% <0.00%> (-84.00%)` | `0.00% <0.00%> (-22.00%)` | |
| [...er/telemetry/prometheus/httpserver/HttpServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [381 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `14.98%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 51.31% +14.98%
- Complexity 2178 3880 +1702
=============================================
Files 812 1029 +217
Lines 20047 25571 +5524
Branches 1908 2507 +599
=============================================
+ Hits 7283 13121 +5838
+ Misses 12222 11344 -878
- Partials 542 1106 +564
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...apm/agent/core/profile/ProfileStatusReference.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzUmVmZXJlbmNlLmphdmE=) | `40.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `33.33% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `76.92% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...lugin/elasticsearch7/query/MetricsQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9NZXRyaWNzUXVlcnlFczdEQU8uamF2YQ==) | `6.25% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ore/plugin/bootstrap/BootstrapInstrumentBoost.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBJbnN0cnVtZW50Qm9vc3QuamF2YQ==) | `15.49% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| ... and [452 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `17.78%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.11% +17.78%
- Complexity 2178 4032 +1854
=============================================
Files 812 1032 +220
Lines 20047 25586 +5539
Branches 1908 2507 +599
=============================================
+ Hits 7283 13847 +6564
+ Misses 12222 10558 -1664
- Partials 542 1181 +639
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../agent/core/context/ids/NewDistributedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvTmV3RGlzdHJpYnV0ZWRUcmFjZUlkLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/RuntimeContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dC5qYXZh) | `41.66% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...server/receiver/zipkin/ZipkinReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJQcm92aWRlci5qYXZh) | `17.24% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...skywalking/apm/agent/core/logging/core/Parser.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhcnNlci5qYXZh) | `60.43% <0.00%> (ø)` | `16.00% <0.00%> (?%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [473 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 175 -637
Lines 20047 4395 -15652
Branches 1908 503 -1405
============================================
- Hits 7283 0 -7283
+ Misses 12222 4395 -7827
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [953 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `53.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 53.45% 0.00% -53.46%
============================================
Files 1790 178 -1612
Lines 38329 4426 -33903
Branches 4219 497 -3722
============================================
- Hits 20487 0 -20487
+ Misses 16857 4426 -12431
+ Partials 985 0 -985
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1767 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `11.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 47.52% +11.19%
- Complexity 2178 3469 +1291
=============================================
Files 812 998 +186
Lines 20047 24596 +4549
Branches 1908 2407 +499
=============================================
+ Hits 7283 11689 +4406
+ Misses 12222 11923 -299
- Partials 542 984 +442
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../agent/core/jvm/memorypool/MemoryPoolProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvTWVtb3J5UG9vbFByb3ZpZGVyLmphdmE=) | `62.50% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...e/plugin/interceptor/enhance/InstMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvSW5zdE1ldGhvZHNJbnRlci5qYXZh) | `50.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...agent/core/boot/AgentPackageNotFoundException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9BZ2VudFBhY2thZ2VOb3RGb3VuZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `4.31%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 32.01% -4.32%
- Complexity 2178 2297 +119
============================================
Files 812 982 +170
Lines 20047 24189 +4142
Branches 1908 2366 +458
============================================
+ Hits 7283 7745 +462
- Misses 12222 15872 +3650
- Partials 542 572 +30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `69.86% <0.00%> (-2.74%)` | `13.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apm/agent/core/profile/ProfileStatusReference.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzUmVmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ore/plugin/bootstrap/BootstrapInstrumentBoost.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBJbnN0cnVtZW50Qm9vc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apm/agent/core/logging/core/SystemOutWriter.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1N5c3RlbU91dFdyaXRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [209 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `21.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 57.81% +21.48%
+ Complexity 2178 845 -1333
=============================================
Files 812 178 -634
Lines 20047 4371 -15676
Branches 1908 490 -1418
=============================================
- Hits 7283 2527 -4756
+ Misses 12222 1528 -10694
+ Partials 542 316 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-15.39%)` | `6.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...ary/module/ServiceNotProvidedRuntimeException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL1NlcnZpY2VOb3RQcm92aWRlZFJ1bnRpbWVFeGNlcHRpb24uamF2YQ==) | | | |
| [...ing/oap/server/storage/plugin/jdbc/SQLBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMQnVpbGRlci5qYXZh) | | | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | | | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | | | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | | | |
| [...server/storage/plugin/jdbc/h2/H2StorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlQ29uZmlnLmphdmE=) | | | |
| [.../configuration/grpc/GRPCConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlndXJhdGlvblByb3ZpZGVyLmphdmE=) | | | |
| [...library/module/ModuleNotFoundRuntimeException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL01vZHVsZU5vdEZvdW5kUnVudGltZUV4Y2VwdGlvbi5qYXZh) | | | |
| ... and [955 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 removed a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 removed a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803584706
@J-Cod3r Can you please review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `13.05%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 36.32% 23.26% -13.06%
+ Complexity 2178 1737 -441
=============================================
Files 812 981 +169
Lines 20047 24044 +3997
Branches 1908 2352 +444
=============================================
- Hits 7283 5595 -1688
- Misses 12222 18045 +5823
+ Partials 542 404 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [294 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 39.81% +3.48%
- Complexity 2178 2849 +671
============================================
Files 812 1012 +200
Lines 20047 25083 +5036
Branches 1908 2440 +532
============================================
+ Hits 7283 9986 +2703
- Misses 12222 14306 +2084
- Partials 542 791 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `12.61%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 40.83% -12.62%
+ Complexity 4110 2997 -1113
=============================================
Files 1790 977 -813
Lines 38329 23932 -14397
Branches 4219 2330 -1889
=============================================
- Hits 20487 9772 -10715
+ Misses 16857 13320 -3537
+ Partials 985 840 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `22.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 31.30% -22.15%
+ Complexity 4110 2387 -1723
=============================================
Files 1790 1011 -779
Lines 38329 25084 -13245
Branches 4219 2441 -1778
=============================================
- Hits 20487 7853 -12634
+ Misses 16857 16627 -230
+ Partials 985 604 -381
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1402 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xuanyu66 commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
xuanyu66 commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803584706
@J-Cod3r Can you please review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803776651
> > @J-Cod3r So, this PR is good for you, right?
>
> right
OK, I am going to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `3.74%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 40.07% +3.74%
- Complexity 2178 2995 +817
============================================
Files 812 1001 +189
Lines 20047 24370 +4323
Branches 1908 2386 +478
============================================
+ Hits 7283 9766 +2483
- Misses 12222 13769 +1547
- Partials 542 835 +293
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...ver/analyzer/provider/jvm/JVMSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL2p2bS9KVk1Tb3VyY2VEaXNwYXRjaGVyLmphdmE=) | `96.87% <0.00%> (-1.05%)` | `16.00% <0.00%> (-1.00%)` | |
| ... and [238 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `12.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 41.16% -12.29%
+ Complexity 4110 3004 -1106
=============================================
Files 1790 1012 -778
Lines 38329 25195 -13134
Branches 4219 2453 -1766
=============================================
- Hits 20487 10372 -10115
+ Misses 16857 14040 -2817
+ Partials 985 783 -202
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1327 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (a3addb6) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a3addb6 differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 172 -640
Lines 20047 4309 -15738
Branches 1908 499 -1409
============================================
- Hits 7283 0 -7283
+ Misses 12222 4309 -7913
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [950 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `11.72%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 48.05% +11.72%
- Complexity 2178 3468 +1290
=============================================
Files 812 982 +170
Lines 20047 24321 +4274
Branches 1908 2374 +466
=============================================
+ Hits 7283 11688 +4405
+ Misses 12222 11648 -574
- Partials 542 985 +443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...walking/apm/agent/core/logging/api/LogManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9hcGkvTG9nTWFuYWdlci5qYXZh) | `50.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pm/agent/core/plugin/bytebuddy/ClassCacheMode.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DbGFzc0NhY2hlTW9kZS5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...kywalking/apm/agent/core/plugin/WitnessFinder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1dpdG5lc3NGaW5kZXIuamF2YQ==) | `47.82% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `21.42% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (7023ecd) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `10.43%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7023ecd differs from pull request most recent head ed1b57a. Consider uploading reports for the commit ed1b57a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 43.01% -10.44%
+ Complexity 4110 3123 -987
=============================================
Files 1790 979 -811
Lines 38329 24021 -14308
Branches 4219 2348 -1871
=============================================
- Hits 20487 10333 -10154
+ Misses 16857 12813 -4044
+ Partials 985 875 -110
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r598103031
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/CreateMementoInterceptor.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.toolkit.activation.log.log4j.v2.x.async;
+
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.StaticMethodsAroundInterceptor;
+
+import java.lang.reflect.Method;
+
+public class CreateMementoInterceptor implements StaticMethodsAroundInterceptor {
+
+ private static final String TRACE_ID = "TRACE_ID";
+
+ @Override
+ public void beforeMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes,
+ MethodInterceptResult result) {
+ if (allArguments[0] instanceof EnhancedInstance) {
+ EnhancedInstance instances = (EnhancedInstance) allArguments[0];
+ ContextManager.getRuntimeContext().put(TRACE_ID, instances.getSkyWalkingDynamicField());
+ }
+ }
+
+ @Override
+ public Object afterMethod(Class clazz, Method method, Object[] allArguments, Class<?>[] parameterTypes,
+ Object ret) {
+ if (ret instanceof EnhancedInstance) {
+ EnhancedInstance instances = (EnhancedInstance) ret;
+ instances.setSkyWalkingDynamicField(ContextManager.getRuntimeContext().get(TRACE_ID));
+ ContextManager.getRuntimeContext().remove(TRACE_ID);
+ }
+ return ret;
Review comment:
Could you explain the usage of the runtime context? This is recommended to use if we have to.
But here, you clearly still could use `allArguments[0]#getSkyWalkingDynamicField` for the `ret` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `36.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 0.00% -36.33%
============================================
Files 812 184 -628
Lines 20047 4503 -15544
Branches 1908 505 -1403
============================================
- Hits 7283 0 -7283
+ Misses 12222 4503 -7719
+ Partials 542 0 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [962 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (c5901b4) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **decrease** coverage by `0.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
- Coverage 36.32% 35.84% -0.49%
- Complexity 2178 2612 +434
============================================
Files 812 1011 +199
Lines 20047 25025 +4978
Branches 1908 2439 +531
============================================
+ Hits 7283 8971 +1688
- Misses 12222 15374 +3152
- Partials 542 680 +138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...erver/library/util/MultipleFilesChangeMonitor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvTXVsdGlwbGVGaWxlc0NoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (-65.00%)` | `0.00% <0.00%> (-13.00%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../oap/server/library/server/ssl/PrivateKeyUtil.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9Qcml2YXRlS2V5VXRpbC5qYXZh) | `0.00% <0.00%> (-15.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `43.54% <0.00%> (-9.68%)` | `5.00% <0.00%> (-1.00%)` | |
| [...server/core/remote/client/RemoteClientManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVtb3RlL2NsaWVudC9SZW1vdGVDbGllbnRNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-3.00%)` | `18.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.61% <0.00%> (-1.89%)` | `10.00% <0.00%> (ø%)` | |
| [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [300 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (80f764e) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `19.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 56.10% +19.77%
+ Complexity 2178 845 -1333
=============================================
Files 812 188 -624
Lines 20047 4504 -15543
Branches 1908 503 -1405
=============================================
- Hits 7283 2527 -4756
+ Misses 12222 1661 -10561
+ Partials 542 316 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-15.39%)` | `6.00% <0.00%> (-2.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...figuration/apollo/ApolloConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwb2xsby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBvbGxvL0Fwb2xsb0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | | | |
| [...ary/module/ServiceNotProvidedRuntimeException.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LW1vZHVsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvbW9kdWxlL1NlcnZpY2VOb3RQcm92aWRlZFJ1bnRpbWVFeGNlcHRpb24uamF2YQ==) | | | |
| [...r/parser/performance/BrowserPerfDataDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9Ccm93c2VyUGVyZkRhdGFEZWNvcmF0b3IuamF2YQ==) | | | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | | | |
| [...core/analysis/metrics/expression/BooleanMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0Jvb2xlYW5NYXRjaC5qYXZh) | | | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | | | |
| [...pache/skywalking/oal/rt/parser/FilterMatchers.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9GaWx0ZXJNYXRjaGVycy5qYXZh) | | | |
| [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | | | |
| ... and [965 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `18.51%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head c5901b4. Consider uploading reports for the commit c5901b4 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
+ Coverage 36.32% 54.84% +18.51%
- Complexity 2178 4058 +1880
=============================================
Files 812 1032 +220
Lines 20047 25596 +5549
Branches 1908 2508 +600
=============================================
+ Hits 7283 14038 +6755
+ Misses 12222 10352 -1870
- Partials 542 1206 +664
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arser/errorlog/listener/ErrorLogRecordSampler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9saXN0ZW5lci9FcnJvckxvZ1JlY29yZFNhbXBsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `73.33% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `83.78% <0.00%> (ø)` | `9.00% <0.00%> (?%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <0.00%> (ø)` | `8.00% <0.00%> (?%)` | |
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <0.00%> (ø)` | `25.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [476 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...c5901b4](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (ed1b57a) into [master](https://codecov.io/gh/apache/skywalking/commit/56425f1c62fe94c4def4ba3a7107a581612a9490?el=desc) (56425f1) will **decrease** coverage by `11.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
=============================================
- Coverage 53.45% 41.90% -11.55%
+ Complexity 4110 3039 -1071
=============================================
Files 1790 1012 -778
Lines 38329 25195 -13134
Branches 4219 2453 -1766
=============================================
- Hits 20487 10558 -9929
+ Misses 16857 13831 -3026
+ Partials 985 806 -179
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1328 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [56425f1...ed1b57a](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#issuecomment-803589900
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=h1) Report
> Merging [#6567](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=desc) (346767c) into [master](https://codecov.io/gh/apache/skywalking/commit/54997d1ecc7e6acf7918344ff4e427b9b7b079a6?el=desc) (54997d1) will **increase** coverage by `6.83%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 346767c differs from pull request most recent head 80f764e. Consider uploading reports for the commit 80f764e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6567 +/- ##
============================================
+ Coverage 36.32% 43.16% +6.83%
- Complexity 2178 3176 +998
============================================
Files 812 982 +170
Lines 20047 24198 +4151
Branches 1908 2366 +458
============================================
+ Hits 7283 10445 +3162
- Misses 12222 12878 +656
- Partials 542 875 +333
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...pm/agent/core/context/SW8ExtensionCarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhFeHRlbnNpb25DYXJyaWVySXRlbS5qYXZh) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `36.36% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `76.92% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `80.95% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `21.42% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...hance/ClassInstanceMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NJbnN0YW5jZU1ldGhvZHNFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | `80.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| ... and [264 more](https://codecov.io/gh/apache/skywalking/pull/6567/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=footer). Last update [54997d1...80f764e](https://codecov.io/gh/apache/skywalking/pull/6567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6567: fix no trace id in async log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6567:
URL: https://github.com/apache/skywalking/pull/6567#discussion_r595944959
##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/log/log4j/v2/x/async/AsyncAppenderMethodInterceptor.java
##########
@@ -32,7 +32,9 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
MethodInterceptResult result) throws Throwable {
if (allArguments[0] instanceof EnhancedInstance) {
EnhancedInstance instances = (EnhancedInstance) allArguments[0];
- instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
+ if (instances.getSkyWalkingDynamicField() == null){
+ instances.setSkyWalkingDynamicField(ContextManager.getGlobalTraceId());
Review comment:
If this is the async mode, it means, it is in another thread. How `ContextManager.getGlobalTraceId()` works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org