You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by John Szakmeister <jo...@szakmeister.net> on 2003/12/18 11:08:40 UTC
Votes for 'svn blame' fixes
As suggested by Jostein, I'm reposting this at the top level.
I think r8023 (fixes a path comparison problem in 'svn blame' with
international characters) and r8030 (updates test blame_tests.py
test script) should be included in the 0.35.0 release and 1.0. Votes?
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Votes for 'svn blame' fixes
Posted by kf...@collab.net.
John Szakmeister <jo...@szakmeister.net> writes:
> I'm not entirely sure I did it the way you wanted but Issue 1658 has been
> created to get r8023, r8030, and r8040 merged in as they all play a role in
> fixing this problem.
>
> Let me know if I didn't do this correctly, and I'll be happy to fix it up.
No, that sounds perfect, thanks!
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Votes for 'svn blame' fixes
Posted by John Szakmeister <jo...@szakmeister.net>.
On Thursday 18 December 2003 10:30, kfogel@collab.net wrote:
> mark benedetto king <mb...@lowlatency.com> writes:
> > > As suggested by Jostein, I'm reposting this at the top level.
> > >
> > > I think r8023 (fixes a path comparison problem in 'svn blame' with
> > > international characters) and r8030 (updates test blame_tests.py
> > > test script) should be included in the 0.35.0 release and 1.0. Votes?
> >
> > +1
>
> [I already replied in the original thread, but am replying here since
> this got rethreaded.]
>
> -1 but only temporarily.
>
> Can you please file an issue for this as a 1.0 candidate change
> instead? I know we put one fix into 0.35.0 already, but that was a
> crash bug in the bindings, not a non-crash bug in core code, and [it
> seemed] it was rather extensively reviewed.
I'm not entirely sure I did it the way you wanted but Issue 1658 has been
created to get r8023, r8030, and r8040 merged in as they all play a role in
fixing this problem.
Let me know if I didn't do this correctly, and I'll be happy to fix it up.
Thanks!
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Votes for 'svn blame' fixes
Posted by John Szakmeister <jo...@szakmeister.net>.
On Thursday 18 December 2003 10:30, kfogel@collab.net wrote:
> [snip]
>
> [I already replied in the original thread, but am replying here since
> this got rethreaded.]
>
> -1 but only temporarily.
>
> Can you please file an issue for this as a 1.0 candidate change
> instead? I know we put one fix into 0.35.0 already, but that was a
> crash bug in the bindings, not a non-crash bug in core code, and [it
> seemed] it was rather extensively reviewed.
>
> Just like any other 1.0 fix, this 'svn blame' fix should be listed and
> it priority compared with the others.
No problem. However, as you probably saw the ra_dav tests were failing due to
with how ra_dav grabbed the repository root URL. I've posted a patch for
that problem as well. I'm going to let it sit until tomorrow just in case I
did something stupid, and then I'm going to open an issue for all 3 since
it's all very intertwined. Look for the new issue tomorrow, as well as a
commit to fix this ra_dav failure. Geesh, who knew it would propagate like
this. :-)
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Votes for 'svn blame' fixes
Posted by kf...@collab.net.
mark benedetto king <mb...@lowlatency.com> writes:
> > As suggested by Jostein, I'm reposting this at the top level.
> >
> > I think r8023 (fixes a path comparison problem in 'svn blame' with
> > international characters) and r8030 (updates test blame_tests.py
> > test script) should be included in the 0.35.0 release and 1.0. Votes?
>
> +1
[I already replied in the original thread, but am replying here since
this got rethreaded.]
-1 but only temporarily.
Can you please file an issue for this as a 1.0 candidate change
instead? I know we put one fix into 0.35.0 already, but that was a
crash bug in the bindings, not a non-crash bug in core code, and [it
seemed] it was rather extensively reviewed.
Just like any other 1.0 fix, this 'svn blame' fix should be listed and
it priority compared with the others.
Thanks,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Votes for 'svn blame' fixes
Posted by mark benedetto king <mb...@lowlatency.com>.
On Thu, Dec 18, 2003 at 06:08:40AM -0500, John Szakmeister wrote:
> As suggested by Jostein, I'm reposting this at the top level.
>
> I think r8023 (fixes a path comparison problem in 'svn blame' with
> international characters) and r8030 (updates test blame_tests.py
> test script) should be included in the 0.35.0 release and 1.0. Votes?
>
+1
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org