You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Jurgen Lust <Ju...@UGent.be> on 2005/07/26 15:51:28 UTC
some x:schedule fixes
Hi,
I've made some modifications/bug fixes to the x:schedule component. See
attachment for patches.
1. I reenabled the tooltip support in the schedule and planner
components. Dan Allen, the author of the domTT javascript library,
changed the license of domTT to Apache License 2.0, allowing us to
include it in MyFaces.
2. fixed bug in SimpleScheduleModel: every day was set to a holiday.
3. during the adaptation of the component to the myfaces codebase, a
dependency on the commons lang library was removed. This introduced a
bug in the ScheduleEntryComparator, resulting in an incorrect layout of
overlapping schedule entries in the day and workweek views. This has now
been fixed.
4. I tried the codeconventions4eclipse.xml :-)
Regards,
Jurgen Lust
Re: some x:schedule fixes
Posted by Sean Schofield <se...@gmail.com>.
Never mind. I did a search and replace. Just remember for next time ;-)
sean
ps. Nice job with this (and to Bruno for porting it)
On 7/26/05, Sean Schofield <se...@gmail.com> wrote:
> Jurgen,
>
> Thanks for the contribution. I tried applying your patch but its got
> a bunch of directory info related to your local path. Can you create
> a new patch from your myfaces dir so I don't have to edit it? I fixed
> your examples patch manually but the sandbox one is longer.
>
> sean
>
> On 7/26/05, Jurgen Lust <Ju...@ugent.be> wrote:
> > Hi,
> >
> > I've made some modifications/bug fixes to the x:schedule component. See
> > attachment for patches.
> >
> > 1. I reenabled the tooltip support in the schedule and planner
> > components. Dan Allen, the author of the domTT javascript library,
> > changed the license of domTT to Apache License 2.0, allowing us to
> > include it in MyFaces.
> > 2. fixed bug in SimpleScheduleModel: every day was set to a holiday.
> > 3. during the adaptation of the component to the myfaces codebase, a
> > dependency on the commons lang library was removed. This introduced a
> > bug in the ScheduleEntryComparator, resulting in an incorrect layout of
> > overlapping schedule entries in the day and workweek views. This has now
> > been fixed.
> > 4. I tried the codeconventions4eclipse.xml :-)
> >
> >
> > Regards,
> >
> > Jurgen Lust
> >
> >
> >
> >
> >
>
Re: some x:schedule fixes
Posted by Bruno Aranda <br...@gmail.com>.
Hi Jurgen, I've already applied your patch and fixed your last JIRA
bug (MYFACES-365). More of this graphicImage bugs might be found,
because we have updated recently the attributes of h:graphicImage to
be compliant with the JSF 1.1 spec.
Hope you have had some rest in the mountains... ;-)
Bruno
2005/7/26, Jurgen Lust <Ju...@ugent.be>:
> Apparently, I forgot patching the html_schedule_attributes and
> html_planner_attributes. See attachment for new patch.
>
>
> On Tue, 2005-07-26 at 09:59 -0400, Sean Schofield wrote:
> > Jurgen,
> >
> > Thanks for the contribution. I tried applying your patch but its got
> > a bunch of directory info related to your local path. Can you create
> > a new patch from your myfaces dir so I don't have to edit it? I fixed
> > your examples patch manually but the sandbox one is longer.
> >
> > sean
> >
> > On 7/26/05, Jurgen Lust <Ju...@ugent.be> wrote:
> > > Hi,
> > >
> > > I've made some modifications/bug fixes to the x:schedule component. See
> > > attachment for patches.
> > >
> > > 1. I reenabled the tooltip support in the schedule and planner
> > > components. Dan Allen, the author of the domTT javascript library,
> > > changed the license of domTT to Apache License 2.0, allowing us to
> > > include it in MyFaces.
> > > 2. fixed bug in SimpleScheduleModel: every day was set to a holiday.
> > > 3. during the adaptation of the component to the myfaces codebase, a
> > > dependency on the commons lang library was removed. This introduced a
> > > bug in the ScheduleEntryComparator, resulting in an incorrect layout of
> > > overlapping schedule entries in the day and workweek views. This has now
> > > been fixed.
> > > 4. I tried the codeconventions4eclipse.xml :-)
> > >
> > >
> > > Regards,
> > >
> > > Jurgen Lust
> > >
> > >
> > >
> > >
> > >
>
>
>
Re: some x:schedule fixes
Posted by Jurgen Lust <Ju...@UGent.be>.
Apparently, I forgot patching the html_schedule_attributes and
html_planner_attributes. See attachment for new patch.
On Tue, 2005-07-26 at 09:59 -0400, Sean Schofield wrote:
> Jurgen,
>
> Thanks for the contribution. I tried applying your patch but its got
> a bunch of directory info related to your local path. Can you create
> a new patch from your myfaces dir so I don't have to edit it? I fixed
> your examples patch manually but the sandbox one is longer.
>
> sean
>
> On 7/26/05, Jurgen Lust <Ju...@ugent.be> wrote:
> > Hi,
> >
> > I've made some modifications/bug fixes to the x:schedule component. See
> > attachment for patches.
> >
> > 1. I reenabled the tooltip support in the schedule and planner
> > components. Dan Allen, the author of the domTT javascript library,
> > changed the license of domTT to Apache License 2.0, allowing us to
> > include it in MyFaces.
> > 2. fixed bug in SimpleScheduleModel: every day was set to a holiday.
> > 3. during the adaptation of the component to the myfaces codebase, a
> > dependency on the commons lang library was removed. This introduced a
> > bug in the ScheduleEntryComparator, resulting in an incorrect layout of
> > overlapping schedule entries in the day and workweek views. This has now
> > been fixed.
> > 4. I tried the codeconventions4eclipse.xml :-)
> >
> >
> > Regards,
> >
> > Jurgen Lust
> >
> >
> >
> >
> >
Re: some x:schedule fixes
Posted by Sean Schofield <se...@gmail.com>.
Jurgen,
Thanks for the contribution. I tried applying your patch but its got
a bunch of directory info related to your local path. Can you create
a new patch from your myfaces dir so I don't have to edit it? I fixed
your examples patch manually but the sandbox one is longer.
sean
On 7/26/05, Jurgen Lust <Ju...@ugent.be> wrote:
> Hi,
>
> I've made some modifications/bug fixes to the x:schedule component. See
> attachment for patches.
>
> 1. I reenabled the tooltip support in the schedule and planner
> components. Dan Allen, the author of the domTT javascript library,
> changed the license of domTT to Apache License 2.0, allowing us to
> include it in MyFaces.
> 2. fixed bug in SimpleScheduleModel: every day was set to a holiday.
> 3. during the adaptation of the component to the myfaces codebase, a
> dependency on the commons lang library was removed. This introduced a
> bug in the ScheduleEntryComparator, resulting in an incorrect layout of
> overlapping schedule entries in the day and workweek views. This has now
> been fixed.
> 4. I tried the codeconventions4eclipse.xml :-)
>
>
> Regards,
>
> Jurgen Lust
>
>
>
>
>