You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-commits@incubator.apache.org by aw...@apache.org on 2006/10/26 21:11:38 UTC
svn commit: r468136 -
/incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java
Author: awiner
Date: Thu Oct 26 14:11:37 2006
New Revision: 468136
URL: http://svn.apache.org/viewvc?view=rev&rev=468136
Log:
ADFFACES-259: commandButton 'action' attribute to invoke other pages does not work on PDAs
Modified:
incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java
Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java?view=diff&rev=468136&r1=468135&r2=468136
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/FormRenderer.java Thu Oct 26 14:11:37 2006
@@ -280,10 +280,10 @@
//this condition is needed for bug 4526850- It ensures that only
//state token and form name parameters are overwritten when there is
//a partial page submission.
- //PH: also include blackberry browser in this condition
+ // (also include blackberry browser in this condition)
if (isPDA(arc) && pprImpl == null)
{
- //PH: Add hidden elements in the form for enabling PPR on IE Mobile.
+ //Add hidden elements in the form for enabling PPR on IE Mobile.
Object domLevel = arc.getAgent().getCapabilities().get(
TrinidadAgent.CAP_DOM);
@@ -296,16 +296,21 @@
FormData formData = arc.getFormData();
if(formData != null)
{
- //PH: add needed values for PIE to enable PPR.
+ // =-=AdamWiner: this isn't really correct - these
+ // parameters should be added by the components that need
+ // them, not globally by the form control
if(isPIE)
{
+ formData.addNeededValue(XhtmlConstants.SOURCE_PARAM);
formData.addNeededValue(XhtmlConstants.EVENT_PARAM);
formData.addNeededValue(XhtmlConstants.PARTIAL_TARGETS_PARAM);
formData.addNeededValue(XhtmlConstants.PARTIAL_PARAM);
}
else
- //PH:add needed values for blackberry.
+ {
+ formData.addNeededValue(XhtmlConstants.SOURCE_PARAM);
formData.addNeededValue(XhtmlConstants.EVENT_PARAM);
+ }
}
}