You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/21 16:12:41 UTC

[GitHub] flink issue #5547: [FLINK-8704] [tests] Port AccumulatorLiveITCase to MiniCl...

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5547
  
    I would ask you to stop working on this issue.
    
    You do not know what changes are required to properly port these tests. Adding a `MiniClusterResource` (or extend `AbstractTestBase`) is unfortunately not enough for the tests that are not covered by #5535 and #5542.
    
    The remaining tests are really difficult to port as they *heavily* rely on internal API's. You see all that code in `verifyResults()`? All of that must be rewritten to rely on a (new!) abstraction that works for both legacy and Flip-6 clusters.
    
    I appreciate you trying to contribute, but this issue is beyond your capabilities.


---