You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/11/25 14:29:42 UTC

[commons-io] branch master updated: Reuse constants

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new b8c6f0ef Reuse constants
b8c6f0ef is described below

commit b8c6f0ef5763187476bb1992149d468840e22b00
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 25 09:29:37 2022 -0500

    Reuse constants
---
 src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTest.java | 3 ++-
 src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTest.java  | 3 ++-
 .../org/apache/commons/io/FileUtilsDeleteDirectoryLinuxTest.java     | 5 +++--
 .../org/apache/commons/io/FileUtilsDeleteDirectoryWindowsTest.java   | 3 ++-
 4 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTest.java b/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTest.java
index 2a0afc7c..138ebdca 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTest.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsCleanDirectoryTest.java
@@ -28,6 +28,7 @@ import java.util.ArrayList;
 import java.util.List;
 
 import org.apache.commons.io.file.AbstractTempDirTest;
+import org.apache.commons.lang3.ArrayUtils;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.DisabledOnOs;
 import org.junit.jupiter.api.condition.OS;
@@ -55,7 +56,7 @@ public class FileUtilsCleanDirectoryTest extends AbstractTempDirTest {
         final Process proc;
 
         try {
-            proc = Runtime.getRuntime().exec(args.toArray(new String[args.size()]));
+            proc = Runtime.getRuntime().exec(args.toArray(ArrayUtils.EMPTY_STRING_ARRAY));
         } catch (final IOException e) {
             return false;
         }
diff --git a/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTest.java b/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTest.java
index 2698353f..8e7194c0 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTest.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsCleanSymlinksTest.java
@@ -24,6 +24,7 @@ import java.io.File;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.ArrayUtils;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
@@ -47,7 +48,7 @@ public class FileUtilsCleanSymlinksTest {
 
         final Process proc;
 
-        proc = Runtime.getRuntime().exec(args.toArray(new String[args.size()]));
+        proc = Runtime.getRuntime().exec(args.toArray(ArrayUtils.EMPTY_STRING_ARRAY));
         return proc.waitFor() == 0;
     }
 
diff --git a/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryLinuxTest.java b/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryLinuxTest.java
index ed9c2efc..d078f152 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryLinuxTest.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryLinuxTest.java
@@ -26,6 +26,7 @@ import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.ArrayUtils;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.DisabledOnOs;
 import org.junit.jupiter.api.condition.OS;
@@ -48,7 +49,7 @@ public class FileUtilsDeleteDirectoryLinuxTest extends FileUtilsDeleteDirectoryB
         final Process proc;
 
         try {
-            proc = Runtime.getRuntime().exec(args.toArray(new String[args.size()]));
+            proc = Runtime.getRuntime().exec(args.toArray(ArrayUtils.EMPTY_STRING_ARRAY));
         } catch (final IOException e) {
             return false;
         }
@@ -67,7 +68,7 @@ public class FileUtilsDeleteDirectoryLinuxTest extends FileUtilsDeleteDirectoryB
 
         final Process proc;
 
-        proc = Runtime.getRuntime().exec(args.toArray(new String[args.size()]));
+        proc = Runtime.getRuntime().exec(args.toArray(ArrayUtils.EMPTY_STRING_ARRAY));
         return proc.waitFor() == 0;
     }
 
diff --git a/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryWindowsTest.java b/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryWindowsTest.java
index 84dee249..521ec6e2 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryWindowsTest.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsDeleteDirectoryWindowsTest.java
@@ -22,6 +22,7 @@ import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.lang3.ArrayUtils;
 import org.junit.jupiter.api.condition.EnabledOnOs;
 import org.junit.jupiter.api.condition.OS;
 
@@ -47,7 +48,7 @@ public class FileUtilsDeleteDirectoryWindowsTest extends FileUtilsDeleteDirector
         args.add(link.getAbsolutePath());
         args.add(res.getAbsolutePath());
 
-        final Process proc = Runtime.getRuntime().exec(args.toArray(new String[args.size()]));
+        final Process proc = Runtime.getRuntime().exec(args.toArray(ArrayUtils.EMPTY_STRING_ARRAY));
         final InputStream errorStream = proc.getErrorStream();
         final int rc = proc.waitFor();
         System.err.print(IOUtils.toString(errorStream, Charset.defaultCharset()));