You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/10/31 13:59:50 UTC

[GitHub] [tinkerpop] spmallette opened a new pull request #1212: TINKERPOP-2309 Bump to Tornado 5.x

spmallette opened a new pull request #1212: TINKERPOP-2309 Bump to Tornado 5.x
URL: https://github.com/apache/tinkerpop/pull/1212
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2309
   
   Removed a test that started failing after the version bump. I assume it no longer is necessary given that the error is "Cannot run the event loop while another loop is running" and I've taken to mean that since asyncio is automatically use when available the test is no longer relevant.
   
   I'm not sure if other work should be done as a result of this upgrade. I came across this comment on ipython while researching the test error I was receiving:
   
   https://github.com/jupyter/notebook/issues/3397#issuecomment-519283894
   
   Not sure I know enough at this time about tornado/asyncio to know what should be done to improve our implementation. If anyone cares to comment or help by making a PR, it would be appreciated.
   
   Builds with `mvn clean install -pl gremlin-python`.
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services