You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (Jira)" <ji...@apache.org> on 2020/05/06 09:56:00 UTC
[jira] [Commented] (TEZ-4171) DAGImp::getDAGStatus should try to
report RUNNING state information correctly
[ https://issues.apache.org/jira/browse/TEZ-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100641#comment-17100641 ]
TezQA commented on TEZ-4171:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m 23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m 46s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 22s{color} | {color:orange} tez-dag: The patch generated 1 new + 78 unchanged - 0 fixed = 79 total (was 78) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 23s{color} | {color:red} tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 34s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 40s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-dag |
| | Switch statement found in org.apache.tez.dag.app.dag.impl.DAGImpl$DagStateChangedCallback.onStateChanged(DAGImpl, DAGState) where default case is missing At DAGImpl.java:DAGState) where default case is missing At DAGImpl.java:[lines 589-597] |
| Failed junit tests | tez.dag.app.dag.impl.TestDAGImpl |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/PreCommit-TEZ-Build/393/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4171 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13002141/TEZ-4171.1.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux bceea8349c73 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 4e4b8e5 |
| Default Java | 1.8.0_252 |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/393/artifact/out/diff-checkstyle-tez-dag.txt |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/393/artifact/out/new-findbugs-tez-dag.html |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/393/artifact/out/patch-unit-tez-dag.txt |
| Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/393/testReport/ |
| Max. process+thread count | 207 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/393/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> DAGImp::getDAGStatus should try to report RUNNING state information correctly
> -----------------------------------------------------------------------------
>
> Key: TEZ-4171
> URL: https://issues.apache.org/jira/browse/TEZ-4171
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Priority: Major
> Attachments: TEZ-4171.1.patch
>
>
> [https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java#L593]
>
> [https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java#L953]
>
> It is possible that the state changed to "RUNNING" and signaling was done. However, if getDAGStatus gets invoked later, it wouldn't receive any signal and ends up waiting until the timeout. For clients trying to report details on SUBMIT–>RUNNING, it ends up giving wrong picture.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)