You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "choo121600 (via GitHub)" <gi...@apache.org> on 2026/03/12 10:55:32 UTC

[I] E2E: Improve Playwright test patterns in events-page.spec.ts [airflow]

choo121600 opened a new issue, #63427:
URL: https://github.com/apache/airflow/issues/63427

   ### Description
   
   Improve Playwright test patterns in dag-tasks.spec.ts and related page object to align with Playwright Best Practices.
   
   This PR focuses on improving test patterns only.
   It does not change test coverage or behavior.
   
   
   ### Checklist
   - [ ] page.waitForFunction() with DOM queries → locator-based waiting
   - [ ] page.waitForTimeout() → state-based waiting
   - [ ] waitForLoadState("networkidle") → wait for specific UI state
   - [ ] Manual assertions → web-first assertions
   - [ ] page.evaluate() for DOM manipulation → observe UI state instead
   - [ ] CSS :has-text() → user-facing locators
   
   ### Scope
   This issue covers improvements in:
   - specs/events-page.spec.ts
   - pages/EventsPage.ts
   
   ### Use case/motivation
   
   _No response_
   
   ### Related issues
   
   Part of #63036
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] E2E: Improve Playwright test patterns in events-page.spec.ts [airflow]

Posted by "linxi507 (via GitHub)" <gi...@apache.org>.
linxi507 commented on issue #63427:
URL: https://github.com/apache/airflow/issues/63427#issuecomment-4088164697

   Hi! I see there is already some work in progress.
   
   I’d love to contribute a small incremental improvement to this issue — 
   for example, improving test patterns in a subset of cases (e.g., specific assertions or one spec file).
   
   Would that be helpful?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] E2E: Improve Playwright test patterns in events-page.spec.ts [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on issue #63427:
URL: https://github.com/apache/airflow/issues/63427#issuecomment-4088228295

   @linxi507 Since there’s already an open PR (#63463), it might be a great opportunity to collaborate by leaving review comments and helping improve it together :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] E2E: Improve Playwright test patterns in events-page.spec.ts [airflow]

Posted by "Aditi102005 (via GitHub)" <gi...@apache.org>.
Aditi102005 commented on issue #63427:
URL: https://github.com/apache/airflow/issues/63427#issuecomment-4047008084

   Hi @choo121600, I would like to work on this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] E2E: Improve Playwright test patterns in events-page.spec.ts [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 closed issue #63427: E2E: Improve Playwright test patterns in events-page.spec.ts
URL: https://github.com/apache/airflow/issues/63427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org