You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/11/25 16:53:48 UTC

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable f...

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/1406

    [FLINK-3054] Remove R (return) type variable from SerializationSchema

    - I removed the `JavaDefaultStringSchema`, `DummyStringSchema`, `StringToByteSerializer` and used the `SimpleStringSchema` everywhere.
    - I removed the `RawSchema`, it was not used anywhere.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink flink3054

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1406
    
----
commit 01fec8c25ba93b5d4619f7e3e932ca208f5eb771
Author: Robert Metzger <rm...@apache.org>
Date:   2015-11-24T16:58:00Z

    [FLINK-3054] Remove R (return) type variable from SerializationSchema

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable f...

Posted by gyk <gi...@git.apache.org>.

Github user gyk commented on the pull request:

    https://github.com/apache/flink/pull/1406#issuecomment-222585371
  
    Now is there any easy way to get raw byte array from Kafka when using `FlinkKafkaConsumer*`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable f...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1406#issuecomment-160159242
  
    Thank you for the review. I'll merge it to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable f...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1406


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable f...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1406#issuecomment-159661154
  
    Big +1 from my side.
    
    It is API breaking, though, so we should add this to the list of API changes for 1.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3054] Remove R (return) type variable from Serial...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1406
  
    I think you can use this class as a reference: https://github.com/apache/flink/blob/2c507f93300ad1b53c477e0939f1f2232187b37f/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/serialization/RawSchema.java



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---