You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@archiva.apache.org by ol...@apache.org on 2013/12/13 05:46:45 UTC

svn commit: r1550637 - /archiva/trunk/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java

Author: olamy
Date: Fri Dec 13 04:46:45 2013
New Revision: 1550637

URL: http://svn.apache.org/r1550637
Log:
add note on possible improvments

Modified:
    archiva/trunk/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java

Modified: archiva/trunk/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java
URL: http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java?rev=1550637&r1=1550636&r2=1550637&view=diff
==============================================================================
--- archiva/trunk/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java (original)
+++ archiva/trunk/archiva-modules/archiva-base/archiva-filelock/src/main/java/org/apache/archiva/common/filelock/DefaultFileLockManager.java Fri Dec 13 04:46:45 2013
@@ -37,7 +37,10 @@ import java.util.concurrent.ConcurrentMa
 public class DefaultFileLockManager
     implements FileLockManager
 {
-    private static final ConcurrentMap<File, Lock> lockFiles = new ConcurrentHashMap<File, Lock>( 64 );
+    // TODO currently we create lock for read and write!!
+    // the idea could be to store lock here with various clients read/write
+    // only read could be a more simple lock and acquire a write lock means waiting the end of all reading threads
+    //private static final ConcurrentMap<File, Lock> lockFiles = new ConcurrentHashMap<File, Lock>( 64 );
 
     private boolean skipLocking = false;