You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by fc...@apache.org on 2023/01/06 08:22:02 UTC

[kyuubi] branch master updated: [KYUUBI #4108] [BUILD] Provide GitHub token to prevent 403 error

This is an automated email from the ASF dual-hosted git repository.

fchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new ae7265c7b [KYUUBI #4108] [BUILD] Provide GitHub token to prevent 403 error
ae7265c7b is described below

commit ae7265c7bb284feb599e79992d5e91e8468a010b
Author: Fu Chen <cf...@gmail.com>
AuthorDate: Fri Jan 6 16:21:52 2023 +0800

    [KYUUBI #4108] [BUILD] Provide GitHub token to prevent 403 error
    
    ### _Why are the changes needed?_
    
    1. Provide GitHub token to prevent 403 error.
    
    https://github.com/apache/kyuubi/actions/runs/3852055295/jobs/6563845498
    
    ```
        data: {
          message: "API rate limit exceeded for 65.52.35.0. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
          documentation_url: 'https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting'
        }
    ```
    
    from [Github docs](https://docs.github.com/en/rest/overview/resources-in-the-rest-api?apiVersion=2022-11-28#rate-limits-for-requests-from-github-actions)
    
    > When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository. For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.
    
    from [actions-setup-minikube docs](https://github.com/manusa/actions-setup-minikube#optional-input-parameters)
    
    > GITHUB_TOKEN secret value to access GitHub REST API with an unlimited number of requests (optional but recommended)
    
    2. bump up minikube from v1.25.2 to v1.28.0
    3. bump up kubernetes from v1.23.3 to v1.25.4
    
    ### _How was this patch tested?_
    
    Pass CI.
    
    Closes #4108 from cfmcgrady/ga.
    
    Closes #4108
    
    d19071153 [Fu Chen] fix ga
    
    Authored-by: Fu Chen <cf...@gmail.com>
    Signed-off-by: Fu Chen <cf...@gmail.com>
---
 .github/workflows/master.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
index 50ef77b96..6bb2658ef 100644
--- a/.github/workflows/master.yml
+++ b/.github/workflows/master.yml
@@ -351,8 +351,9 @@ jobs:
       - name: Setup Minikube
         uses: manusa/actions-setup-minikube@v2.7.2
         with:
-          minikube version: 'v1.25.2'
-          kubernetes version: 'v1.23.3'
+          minikube version: 'v1.28.0'
+          kubernetes version: 'v1.25.4'
+          github token: ${{ secrets.GITHUB_TOKEN }}
       - name: kubectl pre-check
         run: |
           kubectl get serviceaccount