You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/01 22:03:05 UTC

[GitHub] [flink] walterddr commented on a change in pull request #9836: [FLINK-14317] make hadoop history server logs accessible through flink ui

walterddr commented on a change in pull request #9836: [FLINK-14317] make hadoop history server logs accessible through flink ui
URL: https://github.com/apache/flink/pull/9836#discussion_r362345300
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
 ##########
 @@ -180,6 +180,22 @@
 			// default matches heartbeat.timeout so that sticky allocation is not lost on timeouts for local recovery
 			.defaultValue(HeartbeatManagerOptions.HEARTBEAT_TIMEOUT.defaultValue())
 			.withDescription("The timeout in milliseconds for a idle slot in Slot Pool.");
+
+	/**
+	 * Hadoop job history server URL.
+	 */
+	public static final ConfigOption<String> JOB_MANAGER_HADOOP_HISTORYSERVER_URL =
 
 Review comment:
   instead of having the JobManagerOptions to load the hadoop history server logs, I think it makes more sense to have it appeared in `HistoryServer` - Currently Flink Session cluster UI already have ways to show JM/TM logs I was not sure if this is needed for the online Flink UI. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services