You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2019/06/18 14:22:49 UTC
[pulsar] branch master updated: [tests] Scope the dependencies for
spark and storm tests to test scope (#4556)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 5f5b609 [tests] Scope the dependencies for spark and storm tests to test scope (#4556)
5f5b609 is described below
commit 5f5b6096f83bdae37427c6483bfd7cd6cc58a5cd
Author: Sijie Guo <si...@apache.org>
AuthorDate: Tue Jun 18 07:22:42 2019 -0700
[tests] Scope the dependencies for spark and storm tests to test scope (#4556)
*Motivation*
In gitsha b7a5677324a79708fd288fee6e8852f16a08ab6c , it introduced a provided dependency for pulsar-storm-test, which it will fail release process. Since it will attempt to transfer the pom file for `com.twitter:carbonite:pom:1.5.0` which is a dependency comes from storm-server.
*Changes*
Make all the dependencies scoped at test scope for two test modules. So maven release will not attempt to release them.
---
tests/pulsar-spark-test/pom.xml | 18 +++++++++++-------
tests/pulsar-storm-test/pom.xml | 8 +++++++-
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/tests/pulsar-spark-test/pom.xml b/tests/pulsar-spark-test/pom.xml
index 5147673..130aef7 100644
--- a/tests/pulsar-spark-test/pom.xml
+++ b/tests/pulsar-spark-test/pom.xml
@@ -36,9 +36,10 @@
<dependencies>
<dependency>
- <groupId>org.apache.pulsar</groupId>
- <artifactId>pulsar-spark</artifactId>
- <version>${project.version}</version>
+ <groupId>org.apache.pulsar</groupId>
+ <artifactId>pulsar-spark</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
</dependency>
<dependency>
@@ -46,6 +47,7 @@
<artifactId>integration</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
+ <scope>test</scope>
</dependency>
<dependency>
@@ -55,13 +57,15 @@
</dependency>
<dependency>
- <groupId>org.mockito</groupId>
- <artifactId>mockito-core</artifactId>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-streaming_2.10</artifactId>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-streaming_2.10</artifactId>
+ <scope>test</scope>
</dependency>
</dependencies>
diff --git a/tests/pulsar-storm-test/pom.xml b/tests/pulsar-storm-test/pom.xml
index 59af212..82d28c1 100644
--- a/tests/pulsar-storm-test/pom.xml
+++ b/tests/pulsar-storm-test/pom.xml
@@ -39,6 +39,7 @@
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-storm</artifactId>
<version>${project.version}</version>
+ <scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.apache.pulsar</groupId>
@@ -51,7 +52,7 @@
<groupId>org.apache.storm</groupId>
<artifactId>storm-server</artifactId>
<version>${storm.version}</version>
- <scope>provided</scope>
+ <scope>test</scope>
<exclusions>
<exclusion>
<groupId>ch.qos.logback</groupId>
@@ -68,6 +69,7 @@
<groupId>org.apache.pulsar</groupId>
<artifactId>pulsar-broker</artifactId>
<version>${project.version}</version>
+ <scope>test</scope>
</dependency>
<dependency>
@@ -75,6 +77,7 @@
<artifactId>pulsar-broker</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
+ <scope>test</scope>
</dependency>
<dependency>
@@ -82,6 +85,7 @@
<artifactId>managed-ledger-original</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
+ <scope>test</scope>
</dependency>
<dependency>
@@ -92,12 +96,14 @@
<dependency>
<groupId>org.asynchttpclient</groupId>
<artifactId>async-http-client</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.storm</groupId>
<artifactId>storm-core</artifactId>
<version>${storm.version}</version>
+ <scope>test</scope>
<exclusions>
<exclusion>
<groupId>ch.qos.logback</groupId>