You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ghxandsky <gi...@git.apache.org> on 2015/03/10 17:48:50 UTC
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
GitHub user ghxandsky opened a pull request:
https://github.com/apache/cloudstack/pull/108
fix yum install require java => 1.7.0 when build management agent and us...
...age rpm package
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ghxandsky/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit ce65c2320adb464a7cde86360fa72a1c5ccf24f9
Author: Star Guo <gh...@gmail.com>
Date: 2015-03-10T16:46:54Z
fix yum install require java => 1.7.0 when build management agent and usage rpm package
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by ghxandsky <gi...@git.apache.org>.
Github user ghxandsky commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-89127744
@karuturi I'm sorry for this commit, it should be "Requires: java-1.7.0-openjdk" . I make a mistake. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-78122073
looks ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-78201760
looks good. merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-78217494
+1 the merged patch on master does not include the closes #issues string before the signature, can you close it @ghxandsky ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-78202455
just an unrelated note. It would help for easy reading if the commit message text width is set to 72. especially headline.
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by ghxandsky <gi...@git.apache.org>.
Github user ghxandsky commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-89128055
@karuturi Can you craete a new commit and fix it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-89187325
@ghxandsky can you send a new PR, both both master and 4.5 (separately)? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-89206971
@ghxandsky
I fixed it on master yesterday. Please verify.
@bhaisaab
This is not pushed to 4.5
-----Original Message-----
From: "Rohit Yadav" <no...@github.com>
Sent: 03-04-2015 12:05
To: "apache/cloudstack" <cl...@noreply.github.com>
Cc: "Rajani Karuturi" <ra...@gmail.com>
Subject: Re: [cloudstack] fix yum install require java => 1.7.0 when buildmanagement agent and us... (#108)
@ghxandsky can you send a new PR, both both master and 4.5 (separately)? Thanks.
—
Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-88835845
Hi @ghxandsky
After this change, if I install the rpm, its installing java 1.6. I am trying on centos6.3 machine. if I give the version as java-1.7.0-openjdk it succeeds. Any idea why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/108#issuecomment-89913657
@ghxandsky, do you know why java => 1.7.0 is working with centos7 and not with centos63? The surprising thing was, on 6.3 without failing due to missing dependency, it installs java 1.6 even on a system which doesnt have java.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---