You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Vishal Agarwal (JIRA)" <ji...@apache.org> on 2017/02/23 09:41:44 UTC

[jira] [Updated] (ARTEMIS-989) Individual Acknowledge: ActiveMQConnectionFactory.createContext(final int sessionMode) throws exception for ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE

     [ https://issues.apache.org/jira/browse/ARTEMIS-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vishal Agarwal updated ARTEMIS-989:
-----------------------------------
    Description: 
Artemis document says that it supports the Individual acknowledgement https://activemq.apache.org/artemis/docs/1.5.3/pre-acknowledge.html

But passing the ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE  to ActiveMQConnectionFactory.createContext(final int sessionMode) throws the JMSRuntimeException("Invalid Session Mode: " + mode).

Actually there is a discrepancy in "createContext(String userName, String password, int sessionMode)" method. validateSessionMode(int mode) throws the exception but while creating the context(in the same method) ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE. is accepted.

ActiveMQConnection connection = createConnectionInternal(userName, password, false, ActiveMQConnection.TYPE_GENERIC_CONNECTION);
         return connection.createContext(sessionMode);

If we add
         case ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE:
         case ActiveMQJMSConstants.PRE_ACKNOWLEDGE:
in the "validateSessionMode" method it will work fine.

  was:
Artemis document says that it supports the Individual acknowledgement https://activemq.apache.org/artemis/docs/1.5.3/pre-acknowledge.html

But passing the ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE  to ActiveMQConnectionFactory.createContext(final int sessionMode) throws the JMSRuntimeException("Invalid Session Mode: " + mode).

Actually there is a discrepancy in "createContext(String userName, String password, int sessionMode)" method. validateSessionMode(int mode) throws the exception but while creating the context in the same method accept the ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE.

ActiveMQConnection connection = createConnectionInternal(userName, password, false, ActiveMQConnection.TYPE_GENERIC_CONNECTION);
         return connection.createContext(sessionMode);

If we add
         case ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE:
         case ActiveMQJMSConstants.PRE_ACKNOWLEDGE:
in the "validateSessionMode" method it will work fine.


> Individual Acknowledge: ActiveMQConnectionFactory.createContext(final int sessionMode) throws exception for ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-989
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-989
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.5.3
>            Reporter: Vishal Agarwal
>
> Artemis document says that it supports the Individual acknowledgement https://activemq.apache.org/artemis/docs/1.5.3/pre-acknowledge.html
> But passing the ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE  to ActiveMQConnectionFactory.createContext(final int sessionMode) throws the JMSRuntimeException("Invalid Session Mode: " + mode).
> Actually there is a discrepancy in "createContext(String userName, String password, int sessionMode)" method. validateSessionMode(int mode) throws the exception but while creating the context(in the same method) ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE. is accepted.
> ActiveMQConnection connection = createConnectionInternal(userName, password, false, ActiveMQConnection.TYPE_GENERIC_CONNECTION);
>          return connection.createContext(sessionMode);
> If we add
>          case ActiveMQJMSConstants.INDIVIDUAL_ACKNOWLEDGE:
>          case ActiveMQJMSConstants.PRE_ACKNOWLEDGE:
> in the "validateSessionMode" method it will work fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)