[jira] Commented: (FILEUPLOAD-169) FileItemStreamImpl closes underlying stream on LimitedInputStream exception

["Phillip Webb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665080#action_12665080 ] 

Phillip Webb commented on FILEUPLOAD-169:
-----------------------------------------

I am actually not using FileUpload directly but instead relying on a MyFaces Tomahawk component that I am trying to fix up (see https://issues.apache.org/jira/browse/TOMAHAWK-1381).

I am a little confused by the API, there is a setFileSizeMax and a setSizeMax.  sizeMax is the maximum total and fileSizeMax is the maximum per file?  Are you saying that if a FileSizeLimitExceededException is thrown then this exception should be considered fatal and further calls to the iterator will fail?  

I that is the case perhaps some additional doc comments could be added to FileSizeLimitExceededException to indicate that the exception cannot be caught as part of any iterators?

I will try and rework my Tomahawk patch to work as you suggest.

Cheers.


> FileItemStreamImpl closes underlying stream on LimitedInputStream exception
> ---------------------------------------------------------------------------
>
>                 Key: FILEUPLOAD-169
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-169
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Phillip Webb
>            Assignee: Jochen Wiedmann
>             Fix For: 1.3
>
>         Attachments: FILEUPLOAD-169.patch
>
>
> FileUploadBase uses a LimitedInputStream to manage the fileSizeMax limit.  If the limit is exceeded the raiseError message closes the stream and throws a FileSizeLimitExceededException.
> Unfortunately the close method is called with true to close the underlying MultipartStream.  This means that additional calls to FileItemIteratorImpl will fail as findNextItem() throws a MalformedStreamException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.