You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2023/05/12 07:45:36 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3787: [SCB-2794]process unknown parameters so that can compatible to old ve…
liubao68 opened a new pull request, #3787:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3787
…… (#3785)
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3787: [SCB-2794]process unknown parameters so that can compatible to old ve…
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #3787:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3787: [SCB-2794]process unknown parameters so that can compatible to old ve…
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3787:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3787#issuecomment-1545352236
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3787](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9f6ceb) into [2.8.x](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/5dbde62aa722844f3f3eb01bdb8121fe7d7ea30b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5dbde62) will **increase** coverage by `0.01%`.
> The diff coverage is `91.17%`.
> :exclamation: Current head e9f6ceb differs from pull request most recent head d0c0c04. Consider uploading reports for the commit d0c0c04 to get more accurate results
```diff
@@ Coverage Diff @@
## 2.8.x #3787 +/- ##
============================================
+ Coverage 74.39% 74.40% +0.01%
- Complexity 679 681 +2
============================================
Files 1590 1591 +1
Lines 39922 39950 +28
Branches 3647 3650 +3
============================================
+ Hits 29699 29726 +27
+ Misses 8735 8733 -2
- Partials 1488 1491 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ments/producer/ProducerArgumentsMapperCreator.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWludm9jYXRpb24vaW52b2NhdGlvbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zd2FnZ2VyL2ludm9jYXRpb24vYXJndW1lbnRzL3Byb2R1Y2VyL1Byb2R1Y2VyQXJndW1lbnRzTWFwcGVyQ3JlYXRvci5qYXZh) | `79.54% <50.00%> (-3.39%)` | :arrow_down: |
| [...ments/consumer/ConsumerArgumentsMapperCreator.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWludm9jYXRpb24vaW52b2NhdGlvbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zd2FnZ2VyL2ludm9jYXRpb24vYXJndW1lbnRzL2NvbnN1bWVyL0NvbnN1bWVyQXJndW1lbnRzTWFwcGVyQ3JlYXRvci5qYXZh) | `98.07% <92.85%> (-1.93%)` | :arrow_down: |
| [.../pojo/client/TestClientInterfaceForServerTest.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvVGVzdENsaWVudEludGVyZmFjZUZvclNlcnZlclRlc3QuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...tion/arguments/AbstractArgumentsMapperCreator.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWludm9jYXRpb24vaW52b2NhdGlvbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9zd2FnZ2VyL2ludm9jYXRpb24vYXJndW1lbnRzL0Fic3RyYWN0QXJndW1lbnRzTWFwcGVyQ3JlYXRvci5qYXZh) | `98.52% <100.00%> (-0.05%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3787/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org