You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/12/21 22:30:32 UTC

svn commit: r1906152 - /poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/StylesTable.java

Author: fanningpj
Date: Wed Dec 21 22:30:32 2022
New Revision: 1906152

URL: http://svn.apache.org/viewvc?rev=1906152&view=rev
Log:
[github-408] Increase performance of StylesTable.putStyle. Thanks to Jason Mirra. This closes #408

Modified:
    poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/StylesTable.java

Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/StylesTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/StylesTable.java?rev=1906152&r1=1906151&r2=1906152&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/StylesTable.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/model/StylesTable.java Wed Dec 21 22:30:32 2022
@@ -467,10 +467,12 @@ public class StylesTable extends POIXMLD
     public int putStyle(XSSFCellStyle style) {
         CTXf mainXF = style.getCoreXf();
 
-        if(! xfs.contains(mainXF)) {
+        int ret = xfs.indexOf(mainXF);
+        if(ret == -1) {
             xfs.add(mainXF);
+            ret = xfs.size() - 1;
         }
-        return xfs.indexOf(mainXF);
+        return ret;
     }
 
     @Override



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org