You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/12/15 20:57:10 UTC
Review Request 54794: Tweaked
`TeardownTest.RecoveredFrameworkAfterMasterFailover`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54794/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Tweaked `TeardownTest.RecoveredFrameworkAfterMasterFailover`.
Diffs
-----
src/tests/teardown_tests.cpp ce51d207de605699a7d409228cb2e355a4d6facc
Diff: https://reviews.apache.org/r/54794/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 54794: Cleaned up teardown tests slightly.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54794/#review161168
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 15, 2016, 9:13 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54794/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 9:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up teardown tests slightly.
>
>
> Diffs
> -----
>
> src/tests/teardown_tests.cpp ce51d207de605699a7d409228cb2e355a4d6facc
>
> Diff: https://reviews.apache.org/r/54794/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54794: Cleaned up teardown tests slightly.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54794/#review159394
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54495, 53895, 53896, 53897, 54467, 54468, 54380, 54387, 54177, 54178, 54179, 54180, 54181, 54182, 54183, 54232, 54312, 54407, 54408, 54793, 54794]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 15, 2016, 9:13 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54794/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 9:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up teardown tests slightly.
>
>
> Diffs
> -----
>
> src/tests/teardown_tests.cpp ce51d207de605699a7d409228cb2e355a4d6facc
>
> Diff: https://reviews.apache.org/r/54794/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54794: Cleaned up teardown tests slightly.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54794/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 9:13 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
More code cleanup.
Summary (updated)
-----------------
Cleaned up teardown tests slightly.
Repository: mesos
Description (updated)
-------
Cleaned up teardown tests slightly.
Diffs (updated)
-----
src/tests/teardown_tests.cpp ce51d207de605699a7d409228cb2e355a4d6facc
Diff: https://reviews.apache.org/r/54794/diff/
Testing
-------
`make check`
Thanks,
Neil Conway