You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/12/08 20:54:53 UTC
[GitHub] nifi pull request #1310: [NIFI-3159] Add ellipsis to long PG name in access ...
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/1310
[NIFI-3159] Add ellipsis to long PG name in access policies shell
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi NIFI-3159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1310
----
commit 468b32a5f38a9cb7cdcb05fd02fd25bfda3422a5
Author: Scott Aslan <sc...@gmail.com>
Date: 2016-12-08T16:20:51Z
[NIFI-3159] Add ellipsis to long PG name in access policies shell
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1310: [NIFI-3159] Add ellipsis to long PG name in access ...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1310#discussion_r92041070
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-policy-management.js ---
@@ -759,18 +759,23 @@ nf.PolicyManagement = (function () {
});
// build the mark up
- return $('<span>Showing effective policy inherited from Process Group </span>').append($('<span class="link"></span>').text(processGroupName).on('click', function () {
- // close the shell
- $('#shell-close-button').click();
-
- // load the correct group and unselect everything if necessary
- nf.CanvasUtils.enterGroup(processGroupId).done(function () {
- nf.CanvasUtils.getSelection().classed('selected', false);
-
- // inform Angular app that values have changed
- nf.ng.Bridge.digest();
- });
- })).append('<span>.</span>');
+ return $('<span style="position: relative;top: -2px;">Showing effective policy inherited from Process Group </span>').append(
+ $('<span class="link ellipsis" style="max-width: 200px; position: relative; top: 3px;"></span>')
--- End diff --
Yea I see it....I was trying to get it to line up with the "Override this policy" text and with the with this vertical-align it is off. What do you think about keeping the vertical-align and adding
#override-policy-message {
float: left;
position: relative;
top: 1px;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1310: [NIFI-3159] Add ellipsis to long PG name in access ...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1310#discussion_r92043862
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-policy-management.js ---
@@ -759,18 +759,23 @@ nf.PolicyManagement = (function () {
});
// build the mark up
- return $('<span>Showing effective policy inherited from Process Group </span>').append($('<span class="link"></span>').text(processGroupName).on('click', function () {
- // close the shell
- $('#shell-close-button').click();
-
- // load the correct group and unselect everything if necessary
- nf.CanvasUtils.enterGroup(processGroupId).done(function () {
- nf.CanvasUtils.getSelection().classed('selected', false);
-
- // inform Angular app that values have changed
- nf.ng.Bridge.digest();
- });
- })).append('<span>.</span>');
+ return $('<span style="position: relative;top: -2px;">Showing effective policy inherited from Process Group </span>').append(
+ $('<span class="link ellipsis" style="max-width: 200px; position: relative; top: 3px;"></span>')
--- End diff --
I'm pretty sure that the div's (`policy-message, new-policy-message, override-policy-message, and add-local-admin-message`) already align. The only issue was the content of `policy-message`. Specifically, the styles in the ellipsis class causes the surrounding text to shift downwards. Setting the link to `vertical-align: middle` should address this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1310: [NIFI-3159] Add ellipsis to long PG name in access policie...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1310
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1310: [NIFI-3159] Add ellipsis to long PG name in access policie...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1310
Will review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1310: [NIFI-3159] Add ellipsis to long PG name in access ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---