You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eagle.apache.org by julianhyde <gi...@git.apache.org> on 2015/11/18 20:54:26 UTC

[GitHub] incubator-eagle pull request:

Github user julianhyde commented on the pull request:

    https://github.com/apache/incubator-eagle/commit/82cd97fbb5b87fcd264d593ef65bdfca8da0cf04#commitcomment-14481660
  
    you'll want license headers in all source files, even .md files. here's how Calcite does it: https://raw.githubusercontent.com/apache/calcite/master/README.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-eagle pull request:

Posted by Edward Zhang <yo...@gmail.com>.

Sure, I missed this test file. We have license headers for all source
files. Will fix that soon :-)

Thanks
Edward

On Wed, Nov 18, 2015 at 11:54 AM, julianhyde <gi...@git.apache.org> wrote:

> Github user julianhyde commented on the pull request:
>
>
> https://github.com/apache/incubator-eagle/commit/82cd97fbb5b87fcd264d593ef65bdfca8da0cf04#commitcomment-14481660
>
>     you'll want license headers in all source files, even .md files.
> here's how Calcite does it:
> https://raw.githubusercontent.com/apache/calcite/master/README.md
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>