[GitHub] [cassandra] dcapwell commented on a change in pull request #1432: Cassandra 17332

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #1432:
URL: https://github.com/apache/cassandra/pull/1432#discussion_r797818807



##########
File path: test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
##########
@@ -191,6 +193,13 @@ public B withNodeProvisionStrategy(INodeProvisionStrategy.Strategy nodeProvision
             this.nodeProvisionStrategy = nodeProvisionStrategy;
             return (B) this;
         }
+
+        @Override
+        public C createWithoutStarting() throws IOException
+        {
+            Assume.assumeFalse("vnode is not supported", !isAllowVnodes() && getTokenCount() > 1);

Review comment:
       in the dtest api we have
   
   ```
   if (tokenSupplier == null)
                tokenSupplier = evenlyDistributedTokens(nodeCount);
                tokenSupplier = evenlyDistributedTokens(nodeCount, tokenCount);
   ```
   
   so we only care about token count IFF token supplier isn't provided... so only thing I can think of is to also include
   
   `getTokenSupplier().tokens(1).size() == 1` then not vnodes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org